FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: add type hints to client by rinarakaki · Pull Request #302 · googleapis/python-cloud-core · GitHub

This repository was archived by the owner on Feb 13, 2026. It is now read-only.

fix: add type hints to client - #302

Closed
rinarakaki wants to merge 9 commits into
googleapis:mainfrom
rinarakaki:typing
Closed

fix: add type hints to client#302
rinarakaki wants to merge 9 commits into
googleapis:mainfrom
rinarakaki:typing

Conversation

rinarakaki commented Oct 11, 2024
edited
Loading

Copy link
Copy Markdown

Enables googleapis/python-storage#1362.

I checked:

  • mypy -p google.cloud._helpers
  • mypy -p google.cloud.client

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

rinarakaki requested a review from a team October 11, 2024 10:50

conventional-commit-lint-gcf Bot commented Oct 11, 2024
edited
Loading

Copy link
Copy Markdown

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

product-auto-label Bot added the size: s Pull request size is small. label Oct 11, 2024
rinarakaki changed the title chore: add typing fix: add type hints to client Oct 12, 2024
rinarakaki changed the title fix: add type hints to client chore: add type hints to client Oct 15, 2024
rinarakaki changed the title chore: add type hints to client fix: add type hints to client Oct 15, 2024
rinarakaki mentioned this pull request Oct 16, 2024
4 tasks
product-auto-label Bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Oct 21, 2024
rinarakaki closed this by deleting the head repository Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL