FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: remove _ClientFactoryMixin by rinarakaki · Pull Request #305 · googleapis/python-cloud-core · GitHub

This repository was archived by the owner on Feb 13, 2026. It is now read-only.

feat: remove _ClientFactoryMixin - #305

Closed
rinarakaki wants to merge 2 commits into
googleapis:mainfrom
rinarakaki:remove-_ClientFactoryMixin
Closed

feat: remove _ClientFactoryMixin#305
rinarakaki wants to merge 2 commits into
googleapis:mainfrom
rinarakaki:remove-_ClientFactoryMixin

Conversation

Copy link
Copy Markdown

It's a private class and inherited only by Client class, so I simply implemented those methods for Client, removing the ambiguity of arguments *args and **kwargs.

This makes it way easier to add type hints later (#302).

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

rinarakaki requested a review from a team October 16, 2024 12:59
product-auto-label Bot added the size: m Pull request size is medium. label Oct 16, 2024
rinarakaki changed the title Remove _ClientFactoryMixin feat: remove _ClientFactoryMixin Oct 16, 2024

Copy link
Copy Markdown

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

rinarakaki closed this by deleting the head repository Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL