FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs: explain how to create credentials from dict by busunkim96 · Pull Request #109 · googleapis/python-api-core · GitHub

This repository was archived by the owner on Feb 23, 2026. It is now read-only.
/ python-api-core Public archive

docs: explain how to create credentials from dict - #109

Merged
gcf-merge-on-green[bot] merged 3 commits into
masterfrom
busunkim96-patch-1
Dec 14, 2020
ConversationCommits (3)ChecksFiles changed
Merged

docs: explain how to create credentials from dict#109
gcf-merge-on-green[bot] merged 3 commits into
masterfrom
busunkim96-patch-1

Conversation

busunkim96 commented Dec 10, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Explain how to create service account from dictionary.
  • Add newer runtimes (Cloud Functions, Run)
  • Clarify that "App Engine credentials" are only for App Engine Standard Python 2.7
  • Link out to docs explaining service account key file creation
  • Link out to full list of scopes for APIs

For googleapis/google-cloud-python#7291

docs: explain how to create credentials from dict
4796623 
* Explain how to create service account from dictionary.
* Add newer runtimes (Cloud Functions, Run)
* Clarify that App Engine credentials are only for Python 2.7
busunkim96 requested a review from a team December 10, 2020 16:19
google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 10, 2020
tseaver previously approved these changes Dec 10, 2020
View reviewed changes
tseaver dismissed their stale review December 10, 2020 17:50

Failed CI

tseaver suggested changes Dec 10, 2020
View reviewed changes
Comment thread docs/auth.rst
<img src="https://raw.githubusercontent.com/GoogleCloudPlatform/google-cloud-common/master/authentication/reuse-service-account.png">

.. _Google Developers Console: https://console.developers.google.com/project
.. _Google Developers Service Account: https://developers.google.com/accounts/docs/OAuth2ServiceAccount

tseaver Dec 10, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This target is still referenced above. See the failed docs build:

Warning, treated as error:
/tmpfs/src/github/python-api-core/docs/auth.rst:209:Unknown target name: "google developers service account".
nox > Command sphinx-build -W -T -N -b html -d docs/_build/doctrees/ docs/ docs/_build/html/ failed with exit code 2

google-cla Bot commented Dec 14, 2020

Copy link
Copy Markdown

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla Bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Dec 14, 2020

tseaver commented Dec 14, 2020

Copy link
Copy Markdown
Contributor

@googlebot I consent.

google-cla Bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Dec 14, 2020
tseaver added the automerge Merge the pull request once unit tests and other checks pass. label Dec 14, 2020
gcf-merge-on-green Bot merged commit 5dce6d6 into master Dec 14, 2020
gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 14, 2020
tseaver deleted the busunkim96-patch-1 branch December 14, 2020 18:34
This was referenced May 30, 2025
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

silvolu Awaiting requested review from silvolu
crwilcox Awaiting requested review from crwilcox
1 more reviewer
tseaver tseaver approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL