FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: add constraints file by busunkim96 · Pull Request #122 · googleapis/python-api-core · GitHub

This repository was archived by the owner on Feb 23, 2026. It is now read-only.
/ python-api-core Public archive

chore: add constraints file - #122

Merged
gcf-merge-on-green[bot] merged 9 commits into
masterfrom
add-constraints-file
Jan 13, 2021
ConversationCommits (9)ChecksFiles changed
Merged

chore: add constraints file#122
gcf-merge-on-green[bot] merged 9 commits into
masterfrom
add-constraints-file

Conversation

busunkim96 commented Dec 30, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Add constraints file to test lower bounds.

busunkim96 requested a review from a team December 30, 2020 22:36
google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 30, 2020
busunkim96 commented Dec 30, 2020
View reviewed changes
Comment thread testing/constraints-3.6.txt Outdated
busunkim96 commented Dec 30, 2020
View reviewed changes
Comment thread testing/constraints-3.6.txt Outdated
Comment on lines +8 to +16
googleapis-common-protos==1.6.0
protobuf==3.12.0
google-auth==1.21.1
requests==2.18.0
setuptools==34.0.0
six==1.13.0
grpcio==1.29.0
grpcio-gcp==0.2.2
grpcio-gcp==0.2.2 No newline at end of file

busunkim96 Dec 30, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
  • futures is excluded since it is only needed for 2.7.
  • pytz is excluded because there is no range.

    python-api-core/setup.py

    Lines 31 to 45 in b51b7f5

    dependencies = [
    "googleapis-common-protos >= 1.6.0, < 2.0dev",
    "protobuf >= 3.12.0",
    "google-auth >= 1.21.1, < 2.0dev",
    "requests >= 2.18.0, < 3.0.0dev",
    "setuptools >= 34.0.0",
    "six >= 1.13.0",
    "pytz",
    'futures >= 3.2.0; python_version < "3.2"',
    ]
    extras = {
    "grpc": "grpcio >= 1.29.0, < 2.0dev",
    "grpcgcp": "grpcio-gcp >= 0.2.2",
    "grpcio-gcp": "grpcio-gcp >= 0.2.2",
    }

busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 30, 2020
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 30, 2020
tseaver suggested changes Jan 13, 2021
View reviewed changes
Comment thread testing/constraints-3.6.txt Outdated
tseaver suggested changes Jan 13, 2021
View reviewed changes

tseaver left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Fix b0rken CI.

google-cla Bot commented Jan 13, 2021

Copy link
Copy Markdown

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla Bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jan 13, 2021

tseaver commented Jan 13, 2021

Copy link
Copy Markdown
Contributor

@googlebot I consent.

google-cla Bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jan 13, 2021
tseaver added the automerge Merge the pull request once unit tests and other checks pass. label Jan 13, 2021
gcf-merge-on-green Bot merged commit c5fee89 into master Jan 13, 2021
gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 13, 2021
tseaver deleted the add-constraints-file branch January 13, 2021 21:48
busunkim96 mentioned this pull request Apr 2, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
tseaver tseaver approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL