This repository was archived by the owner on Feb 23, 2026. It is now read-only.
feat: HTTPIterator now accepts a page_size parameter to control page … - #197
Merged
jimfulton merged 2 commits intoJun 2, 2021
Merged
feat: HTTPIterator now accepts a page_size parameter to control page …#197jimfulton merged 2 commits into
jimfulton merged 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
jimfulton
marked this pull request as ready for review
May 26, 2021 23:34
chrisrossi
reviewed
May 27, 2021
Comment thread
tests/unit/test_page_iterator.py
Outdated
| def test_page_size_items(self, page_size, max_results, pages): | ||
| path = "/foo" | ||
| NITEMS = 10 | ||
| page_size = 3 |
Copy link
Copy Markdown
There was a problem hiding this comment.
Looks like this is getting set twice, once via "parametrize" and once here.
Sorry, something went wrong.
Copy link
Copy Markdown
Author
There was a problem hiding this comment.
Fixed. Thanks!
Sorry, something went wrong.
(This was left over from before this was parametrized.)
Copy link
Copy Markdown
Author
|
@chrisrossi are you ready to approve? :) |
Sorry, something went wrong.
busunkim96
approved these changes
Jun 2, 2021
Copy link
Copy Markdown
Sorry, I missed this message. Yes, I was, but I don't think my approval would have made it mergeable. |
Sorry, something went wrong.
This was referenced May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
2 more reviewers3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…size
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #194 🦕