feat: add support for 'error_info' by atulep · Pull Request #307 · googleapis/python-api-core · GitHub

Adds error_info field to GoogleAPICallError, as requested in #286.

All returns from _parse_grpc_error_details must return a 2-tuple.

Co-authored-by: Tres Seaver <tseaver@palladion.com>

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot I consent.

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@atulep The CLA bot has (once again) lost its tiny mind. You'll need to remove the cla: no label and add the cla: yes label manually.

@atulep The CLA bot has (once again) lost its tiny mind. You'll need to remove the cla: no label and add the cla: yes label manually.

Hey @tseaver, it seems to complain because email used in the commit "@palladion.com" is different than the one you used to sign CLA with. The docs suggest "If the email address does not match an email found, please ask the contributor to either add their new email address to their CLA or rebase their commits with their correct email address." Can you please do that?

Left one comment, other than that, looks good to me. :)

@atulep

it seems to complain because email used in the commit "@palladion.com" is different than the one you used to sign CLA with.

The error message is incorrect -- all my commits in the googleapis / GoogleCloudPlatform organzations for the past seven years have been signed with that e-mail address, which is also the only one associated with my Github profile. Sometimes (I don't know that pattern) the bot balks at merged through-the-web suggestions (which is the case here).

@atulep

it seems to complain because email used in the commit "@palladion.com" is different than the one you used to sign CLA with.

The error message is incorrect -- all my commits in the googleapis / GoogleCloudPlatform organzations for the past seven years have been signed with that e-mail address, which is also the only one associated with my Github profile. Sometimes (I don't know that pattern) the bot balks at merged through-the-web suggestions (which is the case here).

I checked the internal dashboards, and it shows you signed CLA with a "@gmail.com" address. This is the official instruction I was told to follow:

One of the most common problems is that the git author email in the commit is not an email address associated with a CLA. The solution is to change the git author email to be an address covered by the CLA. That email should also be added to their GitHub account; it doesn't need to be the primary email, but it should be on the account.

I know you're an active contributor, so this is really weird to see an CLA issue. Can you share a similar issue from the past where a Googler manually removed the CLA label? Thank you.

@tswast, @busunkim96 Can one of you please tag in on the manual CLA flip?

@googlebot I fixed it.

@summer-ji-eng @tseaver - finally addressed your feedback. Thanks for your comments!

Requested changes made in 331d6e3

@atulep the CLA flag has to be cleared again after pushing any commit, even a merge.

🚀

@tseaver I manually flipped the flag but it still blocks me from merging.

Looks good, just some nitpicking.

Nit: we can simplify this to

return self._error_info.reason if self._error_info else None

Same here: we can use conditional expressions

And here, same as above.

Nit: it's more idiomatic to use list comprehensions than list and filter.

error_info_type = "type.googleapis.com/google.rpc.ErrorInfo"
error_info = [d for d in details if d.get("@type", "") == error_info_type]

Closing this in favor of #315.

feat: Adds support for error_info.

db97527

atulep requested review from a team and summer-ji-eng November 8, 2021 21:32

google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 8, 2021

Aza Tulepbergenov added 2 commits November 8, 2021 13:33

Merge branch 'main' into feat_error_details2

7c02189

chore: fixes docstring.

cb6ead7

tseaver changed the title feat: Adds support for error_info. feat: add support for 'error_info' Nov 9, 2021

tseaver suggested changes Nov 9, 2021

View reviewed changes

Comment thread google/api_core/exceptions.py Outdated

Update google/api_core/exceptions.py

626b992

Co-authored-by: Tres Seaver <tseaver@palladion.com>

google-cla Bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Nov 9, 2021

chore: fixes flaky test.

24b0467

summer-ji-eng reviewed Nov 10, 2021

View reviewed changes

Comment thread google/api_core/exceptions.py

summer-ji-eng previously requested changes Nov 10, 2021

View reviewed changes

tseaver suggested changes Nov 10, 2021

View reviewed changes

Comment thread tests/unit/test_exceptions.py

Comment thread google/api_core/exceptions.py

tswast added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 10, 2021

google-cla Bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Nov 10, 2021

atulep added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 10, 2021

pr: addresses pr feedback.

331d6e3

google-cla Bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Nov 15, 2021

atulep added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 15, 2021

Merge branch 'main' into feat_error_details2

d62a0dd

google-cla Bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Nov 15, 2021

atulep requested review from summer-ji-eng and tseaver November 15, 2021 20:56

tseaver approved these changes Nov 16, 2021

View reviewed changes

summer-ji-eng approved these changes Nov 17, 2021

View reviewed changes

atulep added the cla: yes This human has signed the Contributor License Agreement. label Nov 17, 2021

google-cla Bot removed the cla: no This human has *not* signed the Contributor License Agreement. label Nov 17, 2021

tswast added cla: yes This human has signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Nov 17, 2021

software-dov approved these changes Nov 19, 2021

View reviewed changes

atulep mentioned this pull request Nov 29, 2021

feat: add support for 'error_info' #315

Merged

atulep closed this Nov 29, 2021

+                  error_info = list(
+                      filter(
+                          lambda detail: detail.get("@type", "")
+                          == "type.googleapis.com/google.rpc.ErrorInfo",
+                          details,
+                      )
+                  )

+                      if not self._error_info:
+                          return None
+                      return self._error_info.reason

feat: add support for 'error_info' by atulep · Pull Request #307 · googleapis/python-api-core · GitHub

Uh oh!

feat: add support for 'error_info' - #307

feat: add support for 'error_info'#307atulep wants to merge 7 commits intogoogleapis:maingoogleapis/python-api-core:mainfrom atulep:feat_error_details2atulep/python-api-core:feat_error_details2Copy head branch name to clipboard

Conversation

atulep commented Nov 8, 2021

Uh oh!

tseaver left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

google-cla Bot commented Nov 9, 2021

Uh oh!

google-cla Bot commented Nov 9, 2021

Uh oh!

google-cla Bot commented Nov 9, 2021

Uh oh!

tseaver commented Nov 9, 2021

Uh oh!

google-cla Bot commented Nov 9, 2021

Uh oh!

tseaver commented Nov 9, 2021

Uh oh!

atulep commented Nov 10, 2021

Uh oh!

Uh oh!

summer-ji-eng left a comment

Choose a reason for hiding this comment

Uh oh!

tseaver commented Nov 10, 2021

Uh oh!

Uh oh!

Uh oh!

atulep commented Nov 10, 2021

Uh oh!

tseaver commented Nov 10, 2021

Uh oh!

vam-google commented Nov 10, 2021

Uh oh!

atulep commented Nov 15, 2021

Uh oh!

tseaver commented Nov 16, 2021

Uh oh!

summer-ji-eng left a comment

Choose a reason for hiding this comment

Uh oh!

atulep commented Nov 17, 2021

Uh oh!

software-dov left a comment

Choose a reason for hiding this comment

Uh oh!

software-dov Nov 19, 2021

Choose a reason for hiding this comment

Uh oh!

software-dov Nov 19, 2021

Choose a reason for hiding this comment

Uh oh!

software-dov Nov 19, 2021

Choose a reason for hiding this comment

Uh oh!

software-dov Nov 19, 2021

Choose a reason for hiding this comment

Uh oh!

atulep commented Nov 29, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

feat: add support for 'error_info'#307
atulep wants to merge 7 commits into
googleapis:mainfrom
atulep:feat_error_details2