This repository was archived by the owner on Feb 23, 2026. It is now read-only.
fix: remove trailing underscore in transcoding - #489
Closed
parthea wants to merge 16 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
1 task
parthea
marked this pull request as ready for review
March 7, 2023 15:58
vchudnov-g
reviewed
Mar 7, 2023
vchudnov-g
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Question about simplifying/robustifying processing...
Sorry, something went wrong.
Comment thread
tests/unit/test_path_template.py
Outdated
Comment thread
google/api_core/path_template.py
Outdated
vchudnov-g
approved these changes
Mar 8, 2023
Comment thread
google/api_core/path_template.py
Outdated
Comment thread
google/api_core/path_template.py
…ub.com/googleapis/python-api-core into remove-trailing-underscore-transcoding
atulep
reviewed
Mar 13, 2023
Comment thread
google/api_core/path_template.py
Copy link
Copy Markdown
Contributor
Author
|
Waiting for approval in go/python-transcoding-reserved-keywords |
Sorry, something went wrong.
BenRKarl
reviewed
Mar 14, 2023
Comment thread
google/api_core/path_template.py
BenRKarl
approved these changes
Mar 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes googleapis/google-cloud-python#15074
Googlers see proposal go/python-transcoding-reserved-keywords
This PR fixes an error seen in googleapis/python-debugger-client#151 which happens when the gapic generator appends an underscore to a field name which is a python reserved keyword. As similar issue was reported in #227 and fixed in #228. Based on comment #227 (comment) it is not possible for fields to have trailing _ at the proto level (Creating a field like this generates an error from the protobuf runtime).
See build log https://github.com/googleapis/python-debugger-client/actions/runs/4292539515/jobs/7479094983 which shows the failure when a request has body with breakpoint_ instead of breakpoint_.