This repository was archived by the owner on Feb 23, 2026. It is now read-only.
fix(dependencies): increase protobuf version - #49
Merged
busunkim96 merged 1 commit intoJun 16, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Increase protobuf version to 3.12.0 for `_internal_create_key`. Closes #48
plamut
approved these changes
Jun 16, 2020
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good.
With protobuf==3.12.0, the following import does not result in an error anymore, unlike in some older protobuf versions:
from google.cloud.pubsub_v1.types import PushConfig
Sorry, something went wrong.
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Jun 16, 2020
🤖 I have created a release \*beep\* \*boop\* --- ### [1.20.1](https://www.github.com/googleapis/python-api-core/compare/v1.20.0...v1.20.1) (2020-06-16) ### Bug Fixes * **dependencies:** increase protobuf version ([#49](https://www.github.com/googleapis/python-api-core/issues/49)) ([1ba6095](https://www.github.com/googleapis/python-api-core/commit/1ba609592968c9d828449b89a3ade3bcaf5edd7f)), closes [#48](https://www.github.com/googleapis/python-api-core/issues/48) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
This was referenced May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase protobuf version to 3.12.0 for _internal_create_key.
See protocolbuffers/protobuf@b99994d for the commit where this was added.
Fixes #48 🦕