FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: fix regression in `bidi` causing `Thread-ConsumeBidirectionalStream caught unexpected exception and will exit` by parthea · Pull Request #562 · googleapis/python-api-core · GitHub

This repository was archived by the owner on Feb 23, 2026. It is now read-only.
/ python-api-core Public archive

fix: fix regression in bidi causing Thread-ConsumeBidirectionalStream caught unexpected exception and will exit #562

Merged
parthea merged 2 commits into from
Dec 1, 2023
Conversation 1 Commits 2 Checks 0 Files changed
Merged

fix: fix regression in bidi causing Thread-ConsumeBidirectionalStream caught unexpected exception and will exit #562

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
536c6d2
chore: partial revert of PR #357
parthea Nov 30, 2023
7440545
add comment
parthea Nov 30, 2023
File filter

Filter by extension

Filter by extension .py  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
8 changes: 6 additions & 2 deletions google/api_core/bidi.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,12 @@ def __init__(self, queue, period=1, initial_request=None):
def _is_active(self):
# Note: there is a possibility that this starts *before* the call
# property is set. So we have to check if self.call is set before
# seeing if it's active.
return self.call is not None and self.call.is_active()
# seeing if it's active. We need to return True if self.call is None.
# See https://github.com/googleapis/python-api-core/issues/560.
if self.call is not None and not self.call.is_active():

vchudnov-g Dec 1, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@parthea

It would be simpler and much clearer to have return self.call is None or self.call.is_active(). This is equivalent to what you have, by DeMorgan's theorem.
return False
else:
return True

def __iter__(self):
if self._initial_request is not None:
Expand Down
Back | FazBrowse Home | New Git URL