FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(v1): resolve issue handling protobuf responses in rest streaming by parthea · Pull Request #608 · googleapis/python-api-core · GitHub

This repository was archived by the owner on Feb 23, 2026. It is now read-only.
/ python-api-core Public archive

fix(v1): resolve issue handling protobuf responses in rest streaming - #608

Closed
parthea wants to merge 5 commits into
v1from
fix-rest-streaming-v1
Closed

fix(v1): resolve issue handling protobuf responses in rest streaming#608
parthea wants to merge 5 commits into
v1from
fix-rest-streaming-v1

Conversation

parthea commented Feb 13, 2024
edited
Loading

Copy link
Copy Markdown
Contributor

The changes in this PR were created using git cherry-pick bcebc92eca69dae81c5e546d526c92b164a6b3b4

These commits were also added to resolve issues with presubmits:

8fb3819
deae4a0
b4cab0d
ba6e647


  • fix: resolve issue handling protobuf responses in rest streaming

  • raise ValueError if response_message_cls is not a subclass of proto.Message or google.protobuf.message.Message

  • remove response_type from pytest.mark.parametrize

  • 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

  • add test for ValueError in response_iterator._grab()

* fix: resolve issue handling protobuf responses in rest streaming

* raise ValueError if response_message_cls is not a subclass of proto.Message or google.protobuf.message.Message

* remove response_type from pytest.mark.parametrize

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* add test for ValueError in response_iterator._grab()

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea requested review from a team February 13, 2024 16:46
product-auto-label Bot added the size: l Pull request size is large. label Feb 13, 2024

parthea commented Feb 13, 2024

Copy link
Copy Markdown
Contributor Author

Prefer #609 and #610

parthea closed this Feb 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL