This repository was archived by the owner on Feb 23, 2026. It is now read-only.
fix: Switch to unittest.mock from mock - #713
Merged
parthea merged 7 commits intoOct 9, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Now that the minimum supported version of Python is 3.7, we can stop using the external mock requirement, and import it from unittest. I have also attempted to keep imports ordered. Fixes googleapis#377
s-t-e-v-e-n-k
force-pushed
the
switch-to-unittest-mock
branch
from
4db4bbf to
5f28e21
Compare
October 2, 2024 03:54
Copy link
Copy Markdown
Contributor
|
@s-t-e-v-e-n-k, general comment: AsyncMock isn't part of the stdlib i.e. unitest.mock for Python 3.7. which we're using in our test code. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Ahh, indeed, AsyncMock was added in 3.8. I'll modify this accordingly. |
Sorry, something went wrong.
AsyncMock is not included in unittest.mock under Python 3.7, so we must fallback to the external mock requirement for that Python version. Only install it for that version. Keep this as a separate commit so it can be reverted when 3.7 isn't supported anymore.
s-t-e-v-e-n-k
force-pushed
the
switch-to-unittest-mock
branch
from
98f3bec to
5583db4
Compare
October 3, 2024 11:44
ohmayr
approved these changes
Oct 9, 2024
This was referenced May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the minimum supported version of Python is 3.7, we can stop using the external mock requirement, and import it from unittest. I have also attempted to keep imports ordered.
Fixes #377
Closes #676
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: