chore: librarian release pull request: 20260108T134327Z - #883
Conversation
Sorry, something went wrong.
Summary of ChangesHello @daniel-sanche, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request initiates a release for the google-api-core library, updating its version to 2.29.0. The update incorporates new features, including mTLS auto-enablement and a public version parsing utility, alongside several critical bug fixes to improve stability and compatibility. Merging this PR will trigger the automated release process. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here. Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Sorry, something went wrong.
There was a problem hiding this comment.
Code Review
This pull request is an automated release PR to bump the version of google-api-core to 2.29.0. The changes include updating the version in version.py and .librarian/state.yaml, and adding a new entry to CHANGELOG.md. My review focuses on the correctness of the generated changelog. I've found that the links in the new changelog entry are incorrect and inconsistent with previous entries, and I've provided a suggestion to fix them.
Sorry, something went wrong.
| ## [2.29.0](https://github.com/googleapis/google-cloud-python/compare/google-api-core-v2.28.1...google-api-core-v2.29.0) (2026-01-08) | ||
|
|
||
|
|
||
| ### Features | ||
|
|
||
| * Auto enable mTLS when supported certificates are detected (#869) ([f8bf6f9610f3e0e7580f223794c3906513e1fa73](https://github.com/googleapis/google-cloud-python/commit/f8bf6f9610f3e0e7580f223794c3906513e1fa73)) | ||
| * make parse_version_to_tuple public (#864) ([c969186f2b66bde1df5e25bbedc5868e27d136f9](https://github.com/googleapis/google-cloud-python/commit/c969186f2b66bde1df5e25bbedc5868e27d136f9)) | ||
|
|
||
|
|
||
| ### Bug Fixes | ||
|
|
||
| * flaky tests due to imprecision in floating point calculation and performance test setup (#865) ([93404080f853699b9217e4b76391a13525db4e3e](https://github.com/googleapis/google-cloud-python/commit/93404080f853699b9217e4b76391a13525db4e3e)) | ||
| * remove call to importlib.metadata.packages_distributions() for py38/py39 (#859) ([628003e217d9a881d24f3316aecfd48c244a73f0](https://github.com/googleapis/google-cloud-python/commit/628003e217d9a881d24f3316aecfd48c244a73f0)) | ||
| * Log version check errors (#858) ([6493118cae2720696c3d0097274edfd7fe2bce67](https://github.com/googleapis/google-cloud-python/commit/6493118cae2720696c3d0097274edfd7fe2bce67)) | ||
| * closes tailing streams in bidi classes. (#851) ([c97b3a004044ebf8b35c2a7ba97409d7795e11b0](https://github.com/googleapis/google-cloud-python/commit/c97b3a004044ebf8b35c2a7ba97409d7795e11b0)) | ||
|
|
There was a problem hiding this comment.
The links in this changelog entry appear to be incorrect. They point to the google-cloud-python repository instead of python-api-core. Additionally, the format of the links is inconsistent with previous entries:
- The version comparison link incorrectly prefixes tags with google-api-core-.
- The commit SHAs in the link text are full-length instead of the conventional short format.
For consistency and correctness, please update the links.
| ## [2.29.0](https://github.com/googleapis/google-cloud-python/compare/google-api-core-v2.28.1...google-api-core-v2.29.0) (2026-01-08) | |
| ### Features | |
| * Auto enable mTLS when supported certificates are detected (#869) ([f8bf6f9610f3e0e7580f223794c3906513e1fa73](https://github.com/googleapis/google-cloud-python/commit/f8bf6f9610f3e0e7580f223794c3906513e1fa73)) | |
| * make parse_version_to_tuple public (#864) ([c969186f2b66bde1df5e25bbedc5868e27d136f9](https://github.com/googleapis/google-cloud-python/commit/c969186f2b66bde1df5e25bbedc5868e27d136f9)) | |
| ### Bug Fixes | |
| * flaky tests due to imprecision in floating point calculation and performance test setup (#865) ([93404080f853699b9217e4b76391a13525db4e3e](https://github.com/googleapis/google-cloud-python/commit/93404080f853699b9217e4b76391a13525db4e3e)) | |
| * remove call to importlib.metadata.packages_distributions() for py38/py39 (#859) ([628003e217d9a881d24f3316aecfd48c244a73f0](https://github.com/googleapis/google-cloud-python/commit/628003e217d9a881d24f3316aecfd48c244a73f0)) | |
| * Log version check errors (#858) ([6493118cae2720696c3d0097274edfd7fe2bce67](https://github.com/googleapis/google-cloud-python/commit/6493118cae2720696c3d0097274edfd7fe2bce67)) | |
| * closes tailing streams in bidi classes. (#851) ([c97b3a004044ebf8b35c2a7ba97409d7795e11b0](https://github.com/googleapis/google-cloud-python/commit/c97b3a004044ebf8b35c2a7ba97409d7795e11b0)) | |
| ## [2.29.0](https://github.com/googleapis/python-api-core/compare/v2.28.1...v2.29.0) (2026-01-08) | |
| ### Features | |
| * Auto enable mTLS when supported certificates are detected (#869) ([f8bf6f9](https://github.com/googleapis/python-api-core/commit/f8bf6f9610f3e0e7580f223794c3906513e1fa73)) | |
| * make parse_version_to_tuple public (#864) ([c969186](https://github.com/googleapis/python-api-core/commit/c969186f2b66bde1df5e25bbedc5868e27d136f9)) | |
| ### Bug Fixes | |
| * flaky tests due to imprecision in floating point calculation and performance test setup (#865) ([9340408](https://github.com/googleapis/python-api-core/commit/93404080f853699b9217e4b76391a13525db4e3e)) | |
| * remove call to importlib.metadata.packages_distributions() for py38/py39 (#859) ([628003e](https://github.com/googleapis/python-api-core/commit/628003e217d9a881d24f3316aecfd48c244a73f0)) | |
| * Log version check errors (#858) ([6493118](https://github.com/googleapis/python-api-core/commit/6493118cae2720696c3d0097274edfd7fe2bce67)) | |
| * closes tailing streams in bidi classes. (#851) ([c97b3a0](https://github.com/googleapis/python-api-core/commit/c97b3a004044ebf8b35c2a7ba97409d7795e11b0)) | |
Sorry, something went wrong.
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release.
Librarian Version: v1.0.1
google-api-core: 2.29.0Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:c8612d3fffb3f6a32353b2d1abd16b61e87811866f7ec9d65b59b02eb452a620
2.29.0 (2026-01-08)
Features
make parse_version_to_tuple public (feat: make parse_version_to_tuple public #864) (c969186f)
Auto enable mTLS when supported certificates are detected (feat: Auto enable mTLS when supported certificates are detected #869) (f8bf6f96)
Bug Fixes
remove call to importlib.metadata.packages_distributions() for py38/py39 (fix: remove call to importlib.metadata.packages_distributions() for py38/py39 #859) (628003e2)
Log version check errors (fix: Log version check errors #858) (6493118c)
flaky tests due to imprecision in floating point calculation and performance test setup (fix: flaky tests due to imprecision in floating point calculation and performance test setup #865) (93404080)
closes tailing streams in bidi classes. (fix: closes tailing streams in bidi classes. #851) (c97b3a00)