fix(dbapi): avoid running % format with no query parameters (#348) · googleapis/python-bigquery@5dd1a5e · GitHub

This repository was archived by the owner on Mar 6, 2026. It is now read-only.

googleapis / python-bigquery Public archive

• Notifications You must be signed in to change notification settings
• Fork 324
• Star 798

• Code
• Issues
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 5dd1a5e

Browse filesBrowse the repository at this point in the historyBrowse files

HemangChothani

authored

fix(dbapi): avoid running % format with no query parameters (#348)

* fix: aviod running %format when no query params * fix: nit * fix: change in unit test

1 parent e51fd45 commit 5dd1a5e
Copy full SHA for 5dd1a5e

2 files changed

+7-1Lines changed: 7 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• google/cloud/bigquery/dbapi
  • cursor.py
• tests/unit
  • test_dbapi_cursor.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎google/cloud/bigquery/dbapi/cursor.py‎

Copy file name to clipboardExpand all lines: google/cloud/bigquery/dbapi/cursor.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -441,7 +441,7 @@ def _format_operation(operation, parameters=None):
441	441	if a parameter used in the operation is not found in the
442	442	``parameters`` argument.
443	443	"""
444		- if parameters is None:
	444	+ if parameters is None or len(parameters) == 0:
445	445	return operation
446	446
447	447	if isinstance(parameters, collections_abc.Mapping):

Collapse file

‎tests/unit/test_dbapi_cursor.py‎

Copy file name to clipboardExpand all lines: tests/unit/test_dbapi_cursor.py

+6Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -601,3 +601,9 @@ def test__format_operation_w_too_short_sequence(self):
601	601	"SELECT %s, %s;",
602	602	("hello",),
603	603	)
	604	+
	605	+ def test__format_operation_w_empty_dict(self):
	606	+ from google.cloud.bigquery.dbapi import cursor
	607	+
	608	+ formatted_operation = cursor._format_operation("SELECT '%f'", {})
	609	+ self.assertEqual(formatted_operation, "SELECT '%f'")

0 commit comments

Comments

0 (0)