This repository was archived by the owner on Mar 6, 2026. It is now read-only.
fix(dbapi): avoid running % format with no query parameters - #348
Merged
tswast merged 4 commits intoOct 29, 2020
Merged
tswast merged 4 commits into
tswast merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
tswast
reviewed
Oct 28, 2020
Comment thread
tests/unit/test_dbapi_cursor.py
Outdated
| def test__format_operation_w_empty_dict(self): | ||
| from google.cloud.bigquery.dbapi import cursor | ||
|
|
||
| formatted_operation = cursor._format_operation("SELECT 1", {},) |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Won't the linter complain about the trailing comma here?
Sorry, something went wrong.
tswast
approved these changes
Oct 28, 2020
tswast
suggested changes
Oct 28, 2020
Comment thread
tests/unit/test_dbapi_cursor.py
Outdated
| from google.cloud.bigquery.dbapi import cursor | ||
|
|
||
| formatted_operation = cursor._format_operation("SELECT 1", {}) | ||
| self.assertEqual(formatted_operation, "SELECT 1") |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Actually, let's put a % sign in this string to catch the reported error
Suggested change
| self.assertEqual(formatted_operation, "SELECT 1") | |
| self.assertEqual(formatted_operation, "SELECT '%f'") |
Sorry, something went wrong.
…into bigquery_issue_346
tswast
approved these changes
Oct 29, 2020
Copy link
Copy Markdown
Contributor
|
Thanks for the quick fix! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #346