FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: adjust assertions about pyarrow column values by plamut · Pull Request #192 · googleapis/python-bigquery · GitHub

This repository was archived by the owner on Mar 6, 2026. It is now read-only.
/ python-bigquery Public archive

test: adjust assertions about pyarrow column values - #192

Merged
shollyman merged 1 commit into
googleapis:masterfrom
plamut:fix-tests
Jul 25, 2020
Merged

test: adjust assertions about pyarrow column values#192
shollyman merged 1 commit into
googleapis:masterfrom
plamut:fix-tests

Conversation

plamut commented Jul 25, 2020
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #193. 🦕

This PR adjusts assertions that seem to have been broken by the most recent pyarrow release. I also tried running the same unit test locally with pyarrow pinned to 0.4.1 (the minimum supported version as per setup.py), and they also passed.

PR checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 25, 2020
plamut marked this pull request as ready for review July 25, 2020 13:27
plamut requested a review from shollyman July 25, 2020 13:27
plamut added the release blocking Required feature/issue must be fixed prior to next release. label Jul 25, 2020
plamut mentioned this pull request Jul 25, 2020
shollyman merged commit e5fecce into googleapis:master Jul 25, 2020
plamut deleted the fix-tests branch July 28, 2020 04:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement. release blocking Required feature/issue must be fixed prior to next release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some pyarrow assertions are broken in unit tests

2 participants


Back | FazBrowse Home | New Git URL