Update table_insert_rows.py - #253
Conversation
Sorry, something went wrong.
Adding information to this example for more efficient streaming. Reduce calls to client.get_table()
plamut
left a comment
There was a problem hiding this comment.
On the surface the change seems sensible, although I cannot really comment on the wording in the comments, as I'm not a native English speaker.
Before merging, though, please make sure that the all the checks pass (linters, tests...), and that commit messages follow the conventional commits guideline, thanks!
Sorry, something went wrong.
| if errors == []: | ||
| try: | ||
| # Stream data to BQ | ||
| client.insert_rows(table_id, selected_fields=schema, rows_to_insert) |
There was a problem hiding this comment.
Positional arguments cannot follow keyword arguments, please change the call.
Sorry, something went wrong.
There was a problem hiding this comment.
Also, still need to check for errors. The API call returns success on parial failure, such as unable to insert a particular row.
Sorry, something went wrong.
Adding information to this example for more efficient streaming. Reduce calls to client.get_table()
This PR is meant to replace #212 due to issues from referencing a release initially. Comments and suggestions were incorporated into this PR.
Fixes #211 🦕