FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: Simplify create_job slightly by jimfulton · Pull Request #893 · googleapis/python-bigquery · GitHub

This repository was archived by the owner on Mar 6, 2026. It is now read-only.
/ python-bigquery Public archive

chore: Simplify create_job slightly - #893

Merged
jimfulton merged 2 commits into
googleapis:v3from
jimfulton:simplify-create-job-slightly
Aug 23, 2021
ConversationCommits (2)ChecksFiles changed
Merged

chore: Simplify create_job slightly#893
jimfulton merged 2 commits into
googleapis:v3from
jimfulton:simplify-create-job-slightly

Conversation

jimfulton commented Aug 23, 2021

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

jimfulton requested review from a team and stephaniewang526 August 23, 2021 19:06
product-auto-label Bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Aug 23, 2021
google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 23, 2021
jimfulton mentioned this pull request Aug 23, 2021
Merged
4 tasks
tseaver reviewed Aug 23, 2021
View reviewed changes
Comment thread google/cloud/bigquery/client.py Outdated
copy_config = copy.deepcopy(job_config)
query_job_config = google.cloud.bigquery.job.QueryJobConfig.from_api_repr(
copy_config
copy.deepcopy(job_config)

tseaver Aug 23, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Are we making a copy because we expect from_api_repr to mutate the dict? The clauses above don't do so.

jimfulton Aug 23, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

No, I made a copy because I didn't pay close enough attention to your suggestion. :)

Fixed.

jimfulton merged commit eed311e into googleapis:v3 Aug 23, 2021
jimfulton deleted the simplify-create-job-slightly branch August 23, 2021 20:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

stephaniewang526 Awaiting requested review from stephaniewang526
1 more reviewer
tseaver tseaver approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL