FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: look for transaction info on child job, not parent job by tswast · Pull Request #978 · googleapis/python-bigquery · GitHub

This repository was archived by the owner on Mar 6, 2026. It is now read-only.
/ python-bigquery Public archive

test: look for transaction info on child job, not parent job - #978

Merged
plamut merged 3 commits into
googleapis:mainfrom
tswast:issue975-transaction_info
Sep 21, 2021
ConversationCommits (3)ChecksFiles changed
Merged

test: look for transaction info on child job, not parent job#978
plamut merged 3 commits into
googleapis:mainfrom
tswast:issue975-transaction_info

Conversation

tswast commented Sep 21, 2021

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #975 🦕

tswast requested review from a team and shollyman September 21, 2021 14:39
google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 21, 2021
product-auto-label Bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Sep 21, 2021
plamut approved these changes Sep 21, 2021
View reviewed changes

plamut left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

So that was it? We might want to document that in the property's docstring?

Edit: And maybe also here in the product docs (it's not obvious that a parent job is not part of the multi-statement transaction, at least not to me 🙃 ).

tswast commented Sep 21, 2021

Copy link
Copy Markdown
Contributor Author

So that was it? We might want to document that in the property's docstring?

That's the theory. According to a backend engineer "Script parent job is not part of the transaction started in the script. And a script can create multiple transactions, e.g., many BEGIN TRANSACTION; ...; COMMIT TRANSACTION; blocks."

Good idea, re: docstring. Added!

plamut approved these changes Sep 21, 2021
View reviewed changes

plamut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the quick docstring update!

One nit, but not essential.

Comment thread google/cloud/bigquery/job/base.py Outdated

tswast commented Sep 21, 2021

Copy link
Copy Markdown
Contributor Author

Sent internal CL 397996384 for review to update the REST API docs.

plamut merged commit fcd6336 into googleapis:main Sep 21, 2021
tswast deleted the issue975-transaction_info branch September 21, 2021 20:49
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
test: look for transaction info on child job, not parent job (googlea…
f24e257 
…pis#978)

* test: look for transaction info on child job, not parent job

* clarify transaction_info docstring

* use sphinx method directive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

shollyman Awaiting requested review from shollyman
2 more reviewers
crwilcox crwilcox approved these changes
plamut plamut approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test TestBigQuery.test_transaction_info is flaky.

3 participants

Back | FazBrowse Home | New Git URL