FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: migrate default branch from master to main by jimfulton · Pull Request #301 · googleapis/python-bigquery-sqlalchemy · GitHub

This repository was archived by the owner on May 16, 2026. It is now read-only.
/ python-bigquery-sqlalchemy Public archive

chore: migrate default branch from master to main - #301

Merged
jimfulton merged 8 commits into
googleapis:mainfrom
jimfulton:migrate-default-branch-to-main
Aug 27, 2021
ConversationCommits (8)ChecksFiles changed
Merged

chore: migrate default branch from master to main#301
jimfulton merged 8 commits into
googleapis:mainfrom
jimfulton:migrate-default-branch-to-main

Conversation

jimfulton commented Aug 25, 2021

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

product-auto-label Bot added the api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. label Aug 25, 2021
google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 25, 2021
jimfulton mentioned this pull request Aug 25, 2021
Merged
plamut reviewed Aug 25, 2021
View reviewed changes

plamut left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Don't forget about docs/conf.py :)

jimfulton commented Aug 25, 2021

Copy link
Copy Markdown
Contributor Author

Don't forget about docs/conf.py :)

That's not a reference to a branch. I assumed, incorrectly, I couldn't change that, but I can! So I will! and owlbot.py too! :)

parthea reviewed Aug 27, 2021
View reviewed changes
Comment thread docs/conf.py Outdated
plamut reviewed Aug 27, 2021
View reviewed changes

plamut left a comment •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I found a few references to the master branch in release-procedure.md and sqlite_master in fauxdbi.py (presumably that's just an arbitrary database name in used in a test query?).

The rest are more or less URLs to repos that didn't the migration to main (yet?).

jimfulton marked this pull request as ready for review August 27, 2021 13:11
jimfulton requested a review from a team August 27, 2021 13:11

jimfulton commented Aug 27, 2021

Copy link
Copy Markdown
Contributor Author

I found a few references to the master branch in release-procedure.md

Yeah, I relied to much on the script. Fixed.

and sqlite_master in fauxdbi.py (presumably that's just an arbitrary database name in used in a test query?).

No, that's the name of a system table and can't be changed.

The rest are more or less URLs to repos that didn't the migration to main (yet?).

There were 2 google links that haven't changed yet. There was an SQLAlchemy link that I removed. It didn't add much, si I removed it.

I think I'm done. :)

plamut commented Aug 27, 2021

Copy link
Copy Markdown

@jimfulton Where are the changes to release-procedure.md, it appears there's a commit missing?

Merge branch 'migrate-default-branch-to-main' of github.com:jimfulton…
b5c0692 
…/python-bigquery-sqlalchemy into migrate-default-branch-to-main

jimfulton commented Aug 27, 2021

Copy link
Copy Markdown
Contributor Author

@jimfulton Where are the changes to release-procedure.md, it appears there's a commit missing?

Sorry, forgot to push.

plamut reviewed Aug 27, 2021
View reviewed changes

plamut left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

A question about a deleted link, the rest looks good now.

Comment thread owlbot.py
plamut approved these changes Aug 27, 2021
View reviewed changes

plamut left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

parthea mentioned this pull request Aug 27, 2021
Closed
jimfulton merged commit 0fad7b0 into googleapis:main Aug 27, 2021
jimfulton deleted the migrate-default-branch-to-main branch August 27, 2021 15:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
parthea parthea left review comments
plamut plamut approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL