FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: add docfx session to noxfile, normalize by tseaver · Pull Request #100 · googleapis/python-bigtable · GitHub

This repository was archived by the owner on Apr 1, 2026. It is now read-only.
/ python-bigtable Public archive

chore: add docfx session to noxfile, normalize - #100

Merged
gcf-merge-on-green[bot] merged 2 commits into
masterfrom
chore-add-docfx-session
Aug 5, 2020
ConversationCommits (2)ChecksFiles changed
Merged

chore: add docfx session to noxfile, normalize#100
gcf-merge-on-green[bot] merged 2 commits into
masterfrom
chore-add-docfx-session

Conversation

tseaver commented Aug 5, 2020

Copy link
Copy Markdown
Contributor

Unbreaking the docs-presubmit build.

google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 5, 2020

tmatsuo commented Aug 5, 2020

Copy link
Copy Markdown
Contributor

@tseaver Thanks, I think we should also run synthtool to have other changes, in order to see if the test is actually passing.

tseaver commented Aug 5, 2020

Copy link
Copy Markdown
Contributor Author

@tmatsuo I lost my synthtool-fu during my hiatus. Can I just get my local copy updated to current master and run? Are there new OS-level dependencies?

tmatsuo commented Aug 5, 2020

Copy link
Copy Markdown
Contributor

@tseaver Maybe I can add a commit to the branch.

For the record, I was told there is a dependency on bazel.

tmatsuo commented Aug 5, 2020

Copy link
Copy Markdown
Contributor

I think you rebased, that should work too. Thanks!

tseaver commented Aug 5, 2020

Copy link
Copy Markdown
Contributor Author

@tmatsuo I merged #99 to master, and then merged it here, which seems to be getting docs-presubmit to actually run.

tmatsuo commented Aug 5, 2020

Copy link
Copy Markdown
Contributor

The docs-presubmit is passing :)

Do you know why the samples are failing?

tmatsuo commented Aug 5, 2020

Copy link
Copy Markdown
Contributor

At a glance, the test has sth like time.sleep(10), so they might be eventually consistent tests.

tseaver commented Aug 5, 2020

Copy link
Copy Markdown
Contributor Author

@tmatsuo We are hitting quota issues, breaking snippets / systests / samples.

tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 5, 2020
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 5, 2020
tseaver added the automerge Merge the pull request once unit tests and other checks pass. label Aug 5, 2020
gcf-merge-on-green Bot merged commit fda22ae into master Aug 5, 2020
tseaver deleted the chore-add-docfx-session branch August 5, 2020 20:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

crwilcox Awaiting requested review from crwilcox
busunkim96 Awaiting requested review from busunkim96
1 more reviewer
tmatsuo tmatsuo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL