This repository was archived by the owner on Apr 1, 2026. It is now read-only.
fix: use single routing metadata header - #1005
Merged
daniel-sanche merged 5 commits intoJul 30, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
daniel-sanche
marked this pull request as ready for review
July 29, 2024 19:12
jackdingilian
approved these changes
Jul 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewerAssignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1004, and adds a unit test to ensure only a single routing header is sent
A longer term fix is proposed in the gapic generator at googleapis/gapic-generator-python#2079, but this patch will work until the upstream is updated