This repository was archived by the owner on Apr 1, 2026. It is now read-only.
feat: add basic interceptor to client - #1206
Merged
daniel-sanche merged 13 commits intoNov 20, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
chalmerlowe
previously approved these changes
Oct 7, 2025
chalmerlowe
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
I am approving, pending:
- See the #QUESTIONs and determine whether any changes need to be made, if no, then carry on.
- See the #PREFERENCEs and #NITs and see if there is merit to including them. If no, then carry on.
Sorry, something went wrong.
Comment thread
google/cloud/bigtable/data/_async/client.py
Outdated
Comment thread
google/cloud/bigtable/data/_async/client.py
Outdated
Comment thread
tests/system/data/test_system_autogen.py
| row_key = b"bulk_mutate" | ||
| new_value = uuid.uuid4().hex.encode() | ||
| row_key, mutation = self._create_row_and_mutation( | ||
| (row_key, mutation) = self._create_row_and_mutation( |
Copy link
Copy Markdown
There was a problem hiding this comment.
#PREFERENCE
Why are we encapsulating all of these values in parens? To the best of my knowledge, this is not required by either PEP 8 or the Google Python Style Guide nor have I heard it referred to as a best practice. I don't see any other examples of this practice anywhere else in this codebase.
Feels unnecessary. I recommend ditching them unless we have a really good reason to add them.
Suggested change
| (row_key, mutation) = self._create_row_and_mutation( | |
| row_key, mutation = self._create_row_and_mutation( |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
This code auto-generated, so this wasn't a conscious choice. Something must have changed in how black is post processing the generated code.
It feels unnecessary to me too, but it doesn't bother me enough to fight with the generation system to change it back
Sorry, something went wrong.
Comment thread
tests/unit/data/test_sync_up_to_date.py
Comment thread
tests/unit/data/_async/test_metrics_interceptor.py
Outdated
Comment thread
google/cloud/bigtable/data/_async/metrics_interceptor.py
Outdated
daniel-sanche
enabled auto-merge (squash)
November 19, 2025 22:44
chalmerlowe
approved these changes
Nov 20, 2025
chalmerlowe
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This was referenced Nov 20, 2025
This was referenced Dec 16, 2025
daniel-sanche
added a commit
that referenced
this pull request
Dec 16, 2025
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.7.0 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:b8058df4c45e9a6e07f6b4d65b458d0d059241dd34c814f151c8bf6b89211209 <details><summary>google-cloud-bigtable: 2.35.0</summary> ## [2.35.0](v2.34.0...v2.35.0) (2025-12-16) ### Features * add basic interceptor to client (#1206) ([6561cfa](6561cfac)) * Add encodings for STRUCT and the Timestamp type ([72dfdc4](72dfdc44)) * add PeerInfo proto in Bigtable API ([72dfdc4](72dfdc44)) * Add Type API updates needed to support structured keys in materialized views ([72dfdc4](72dfdc44)) * support mTLS certificates when available (#1249) ([ca20219](ca20219c)) ### Bug Fixes * re-export AddToCell for consistency (#1241) ([2a5baf1](2a5baf11)) * async client uses fixed grace period (#1236) ([544db1c](544db1cd)) * Deprecate credentials_file argument ([72dfdc4](72dfdc44)) * Add ReadRows/SampleRowKeys bindings for materialized views ([72dfdc4](72dfdc44)) * retry cancelled errors (#1235) ([e3fd5d8](e3fd5d86)) </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
Assignees
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new grpc interceptor to the client, to be used for metrics collection. Currently, the interceptor is a no-op. Interception logic will be added in a future change.