FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: require `six>=1.12.0` and `google-api-core>=1.21.0` by tswast · Pull Request #46 · googleapis/python-cloud-core · GitHub

This repository was archived by the owner on Feb 13, 2026. It is now read-only.
/ python-cloud-core Public archive

deps: require six>=1.12.0 and google-api-core>=1.21.0 - #46

Merged
busunkim96 merged 1 commit into
googleapis:masterfrom
tswast:issue45-collections_abc
Nov 18, 2020
ConversationCommits (1)ChecksFiles changed
Merged

deps: require six>=1.12.0 and google-api-core>=1.21.0#46
busunkim96 merged 1 commit into
googleapis:masterfrom
tswast:issue45-collections_abc

Conversation

tswast commented Nov 18, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • six>=1.12.0 is to support legacy App Engine standard runtimes
  • google-api-core>=1.21.0 is needed for DuplicateCredentialArgs
    exception

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #45 🦕

deps: require six>=1.12.0 and google-api-core>=1.21.0
42aa73d 
* `six>=1.12.0` is to support legacy App Engine standard runtimes
* `google-api-core>=1.21.0` is needed for `DuplicateCredentialArgs`
  exception
tswast requested a review from a team November 18, 2020 15:42
google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 18, 2020

tswast commented Nov 18, 2020

Copy link
Copy Markdown
Contributor Author

constraints-PY_VER.txt pattern is following the pattern I used here: googleapis/python-bigquery#263 and hope to add to the generated noxfiles here: googleapis/synthtool#839

busunkim96 approved these changes Nov 18, 2020
View reviewed changes

busunkim96 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you @tswast!

busunkim96 merged commit a97b9ca into googleapis:master Nov 18, 2020
tswast deleted the issue45-collections_abc branch November 18, 2020 15:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
busunkim96 busunkim96 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ImportError: cannot import six.moves.collections_abc

2 participants

Back | FazBrowse Home | New Git URL