This repository was archived by the owner on Dec 31, 2023. It is now read-only.
feat: update to the latest version of the code generator - #147
Merged
gcf-merge-on-green[bot] merged 23 commits intoNov 16, 2021
Merged
feat: update to the latest version of the code generator#147gcf-merge-on-green[bot] merged 23 commits into
gcf-merge-on-green[bot] merged 23 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Blocked by googleapis/google-cloud-python#10566 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@parthea I chatted about this with @vam-google over chat. This library is relatively new and still in preview, so I think it's reasonable to ask folks to use a newer version of google-api-core to use it (even if it requires bumping versions of other libraries they are using together) The alternative is back-porting quite a few significant changes to the v1 branch of google-api-core library, which I would prefer not to do at this point. |
Sorry, something went wrong.
….com/googleapis/python-compute into use-the-latest-python-code-generator
….com/googleapis/python-compute into use-the-latest-python-code-generator
parthea
commented
Nov 11, 2021
parthea
marked this pull request as ready for review
November 11, 2021 00:24
Copy link
Copy Markdown
Contributor
|
Those tests that are failing need to be somehow refactored, as they keep failing despite the fact that we use the 'gcloud_project_env': 'BUILD_SPECIFIC_GCLOUD_PROJECT' setting. Do you think turning the two tests that live in test_sample_default_values.py could stop those failures? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Seems like merging the two tests did the trick :) |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@busunkim96 This is ready for review |
Sorry, something went wrong.
busunkim96
reviewed
Nov 12, 2021
Comment thread
google/cloud/compute_v1/types/compute_small.py
Outdated
Comment thread
owlbot.py
Comment thread
samples/snippets/sample_default_values.py
Outdated
Copy link
Copy Markdown
Contributor
Author
|
@busunkim96 Please could you take another look? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
This is ready for review |
Sorry, something went wrong.
busunkim96
approved these changes
Nov 16, 2021
gcf-merge-on-green
Bot
deleted the
use-the-latest-python-code-generator
branch
November 16, 2021 16:38
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Nov 16, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [0.8.0](https://www.github.com/googleapis/python-compute/compare/v0.7.0...v0.8.0) (2021-11-16) ### Features * support self-signed JWT flow for service accounts ([de739a1](https://www.github.com/googleapis/python-compute/commit/de739a1b2c94648135bf62bc2aff23c2896a9b2d)) * update to the latest version of the code generator ([#147](https://www.github.com/googleapis/python-compute/issues/147)) ([de739a1](https://www.github.com/googleapis/python-compute/commit/de739a1b2c94648135bf62bc2aff23c2896a9b2d)) ### Bug Fixes * add 'dict' annotation type to 'request' ([de739a1](https://www.github.com/googleapis/python-compute/commit/de739a1b2c94648135bf62bc2aff23c2896a9b2d)) * **deps:** require google-api-core >=2.2.0 ([de739a1](https://www.github.com/googleapis/python-compute/commit/de739a1b2c94648135bf62bc2aff23c2896a9b2d)) * **deps:** require proto-plus >=1.19.7 ([de739a1](https://www.github.com/googleapis/python-compute/commit/de739a1b2c94648135bf62bc2aff23c2896a9b2d)) ### Documentation * list oneofs in docstring ([de739a1](https://www.github.com/googleapis/python-compute/commit/de739a1b2c94648135bf62bc2aff23c2896a9b2d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
Assignees
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compute protos are now available in googleapis/googleapis, and the generated code is also available in googleapis/googleapis-gen here. This PR pulls in the latest version of the generated client from googleapis-gen, which may have significant differences. I've added the do not merge label while we discuss whether any differences could break user code.
This PR also deletes synth.py and adds configuration files for owl bot. owl bot will save time for maintainers as it will automatically open PRs when there are updates in googleapis-gen without requiring maintainers to run synthtool to build the client from protos. Additionally, similar to autosynth, PRs will be automatically opened when there are updates to templated files.
fix(deps): require google-api-core >=2.2.0
fix(deps): require proto-plus >=1.19.7
docs: list oneofs in docstring
fix: add 'dict' annotation type to 'request'
feat: support self-signed JWT flow for service accounts
chore(samples): Merging usage bucket tests into one, to avoid race conditions