FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: delete deprecated Dataproc v1beta2 API client by parthea · Pull Request #253 · googleapis/python-dataproc · GitHub

This repository was archived by the owner on Nov 29, 2023. It is now read-only.
/ python-dataproc Public archive

feat: delete deprecated Dataproc v1beta2 API client - #253

Merged
gcf-merge-on-green[bot] merged 9 commits into
mainfrom
owl-bot-f74e8a85-e49b-419e-b9b3-ab196ba40aff
Sep 2, 2021
ConversationCommits (9)ChecksFiles changed
Merged

feat: delete deprecated Dataproc v1beta2 API client#253
gcf-merge-on-green[bot] merged 9 commits into
mainfrom
owl-bot-f74e8a85-e49b-419e-b9b3-ab196ba40aff

Conversation

parthea commented Aug 31, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

See #249. Googlers see internal bug b/197576296.

Committer: @medb
PiperOrigin-RevId: 392723737

Source-Link: googleapis/googleapis@8bf048d

Source-Link: https://github.com/googleapis/googleapis-gen/commit/f45e49bb22b39098ca73b18228b2014ab931d38a

parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 31, 2021
parthea requested a review from a team August 31, 2021 10:50
product-auto-label Bot added the api: dataproc Issues related to the googleapis/python-dataproc API. label Aug 31, 2021
google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 31, 2021
yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 31, 2021
parthea requested a review from leahecole August 31, 2021 11:01
parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Aug 31, 2021

parthea commented Aug 31, 2021

Copy link
Copy Markdown
Contributor Author

@leahecole Please could you review/approve?

yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 31, 2021

busunkim96 commented Aug 31, 2021

Copy link
Copy Markdown
Contributor

The changes LGTM. Is the intent to take a major bump in this library?

parthea commented Aug 31, 2021

Copy link
Copy Markdown
Contributor Author

Yes, I'd like to take a major bump. I'll mark this PR as Do Not Merge while I confirm with the broader team.

parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 31, 2021

leahecole commented Aug 31, 2021

Copy link
Copy Markdown
Contributor

I think it's fine by me but also want to cc @loferris - they're working on Dataproc stuff here and there and I want to make sure they see this too

parthea requested a review from busunkim96 September 1, 2021 10:58
parthea assigned loferris and unassigned leahecole Sep 1, 2021
parthea added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 1, 2021
parthea added the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 1, 2021
yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 1, 2021
parthea changed the title feat!: delete deprecated Dataproc v1beta2 API client feat: delete deprecated Dataproc v1beta2 API client Sep 1, 2021
parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 1, 2021
parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Sep 1, 2021
yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 1, 2021
parthea added the automerge Merge the pull request once unit tests and other checks pass. label Sep 2, 2021
gcf-merge-on-green Bot merged commit b0db6da into main Sep 2, 2021
gcf-merge-on-green Bot deleted the owl-bot-f74e8a85-e49b-419e-b9b3-ab196ba40aff branch September 2, 2021 00:14
gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 2, 2021
SamWheating mentioned this pull request Sep 23, 2021
Closed
2 tasks
mik-laj mentioned this pull request Sep 24, 2021
Closed
parthea mentioned this pull request Sep 25, 2021
Merged
gcf-merge-on-green Bot pushed a commit that referenced this pull request Sep 29, 2021
chore: release as 3.0.0 (#273)
3bdeaa7 
Closes #271 

We need to bump the major version as the dataproc v1beta2 client was deleted in #253. The last version that contains the v1beta2 client is version 2.5.0. See #271 for more information.

feat: delete deprecated Dataproc v1beta2 API client
docs: update cluster sample

Release-As: 3.0.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

leahecole Awaiting requested review from leahecole
1 more reviewer
busunkim96 busunkim96 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

loferris

Labels

api: dataproc Issues related to the googleapis/python-dataproc API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL