FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs(samples): Snippet for submitting jobs to cluster pools using templates by datasherlock · Pull Request #440 · googleapis/python-dataproc · GitHub

This repository was archived by the owner on Nov 29, 2023. It is now read-only.
/ python-dataproc Public archive

docs(samples): Snippet for submitting jobs to cluster pools using templates - #440

Closed
datasherlock wants to merge 7 commits into
googleapis:mainfrom
datasherlock:main
ConversationCommits (7)ChecksFiles changed
Closed

docs(samples): Snippet for submitting jobs to cluster pools using templates#440
datasherlock wants to merge 7 commits into
googleapis:mainfrom
datasherlock:main

Conversation

datasherlock commented Jun 17, 2022 •
edited
Loading

Copy link
Copy Markdown

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

Create instantiate_inline_workflow_template_cluster_selector.py
eb41294 
Added a snipped to demonstrate submitting jobs to dataproc cluster pools using inline workflow templates
Merge pull request #1 from datasherlock/cluster-selector-snippet
46df9f7 
Create instantiate_inline_workflow_template_cluster_selector.py
datasherlock requested a review from a team as a code owner June 17, 2022 12:15
datasherlock requested review from a team and kurtisvg June 17, 2022 12:15
product-auto-label Bot added size: m Pull request size is medium. api: dataproc Issues related to the googleapis/python-dataproc API. labels Jun 17, 2022

snippet-bot Bot commented Jun 17, 2022 •
edited
Loading

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

kurtisvg requested review from dandhlee and kurtisvg and removed request for kurtisvg June 17, 2022 15:41
parthea changed the title Snippet for submitting jobs to cluster pools using templates docs(samples): Snippet for submitting jobs to cluster pools using templates Jul 15, 2022
parthea suggested changes Jul 15, 2022
View reviewed changes

parthea left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please could you add a *_test.py file also, similar to this one?

product-auto-label Bot added the samples Issues that are directly related to samples. label Jul 15, 2022
datasherlock mentioned this pull request Aug 16, 2022
Open

meredithslota commented Sep 9, 2022

Copy link
Copy Markdown
Contributor

Please also update the region tag to include the product prefix.

datasherlock commented Oct 10, 2022

Copy link
Copy Markdown
Author

I have added a pytest file and also modified the region tags to include the prefixes

datasherlock removed their assignment Oct 11, 2022
datasherlock requested review from parthea and removed request for dandhlee October 11, 2022 04:04

dandhlee commented Nov 22, 2022

Copy link
Copy Markdown
Contributor

Hey @datasherlock, we're consolidating handwritten samples to https://github.com/GoogleCloudPlatform/python-docs-samples. Could you open this PR on python-docs-samples instead? I can help take a look at the PR.

dandhlee closed this Nov 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

parthea Awaiting requested review from parthea

Assignees

No one assigned

Labels

api: dataproc Issues related to the googleapis/python-dataproc API. samples Issues that are directly related to samples. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL