FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: code clean up by slowy07 · Pull Request #351 · googleapis/python-dialogflow · GitHub

This repository was archived by the owner on Dec 17, 2023. It is now read-only.
/ python-dialogflow Public archive

chore: code clean up - #351

Merged
gcf-merge-on-green[bot] merged 4 commits into
googleapis:masterfrom
slowy07:fixing
Jul 26, 2021
ConversationCommits (4)ChecksFiles changed
Merged

chore: code clean up#351
gcf-merge-on-green[bot] merged 4 commits into
googleapis:masterfrom
slowy07:fixing

Conversation

slowy07 commented Jul 26, 2021

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #350 🦕

slowy07 requested a review from a team July 26, 2021 01:31
google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 26, 2021
product-auto-label Bot added the api: dialogflow Issues related to the googleapis/python-dialogflow API. label Jul 26, 2021
parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jul 26, 2021
yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 26, 2021
parthea changed the title Fixing over-indented and should 'not in' chore: code clean up Jul 26, 2021
parthea approved these changes Jul 26, 2021
View reviewed changes

parthea left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, Thanks @slowy07 !

parthea added the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jul 26, 2021
gcf-merge-on-green Bot merged commit 61123e7 into googleapis:master Jul 26, 2021
gcf-merge-on-green Bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jul 26, 2021

slowy07 commented Jul 26, 2021

Copy link
Copy Markdown
Contributor Author

LGTM, Thanks @slowy07 !

thank you so much @parthea !

parthea mentioned this pull request Jul 26, 2021
Merged
gcf-merge-on-green Bot pushed a commit to googleapis/gapic-generator-python that referenced this pull request Jul 26, 2021
chore: clean up fixup scripts (#963)
1ba3b73 
Incorporate changes from googleapis/python-dialogflow#351 in templated fixup script files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
parthea parthea approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: dialogflow Issues related to the googleapis/python-dialogflow API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

continuation line over-indented for hanging indent, and lambda logical

3 participants

Back | FazBrowse Home | New Git URL