chore: librarian update image pull request: 20260219T182100Z - #1171
chore: librarian update image pull request: 20260219T182100Z#1171parthea wants to merge 2 commits into
Conversation
Sorry, something went wrong.
…prod/images-prod/python-librarian-generator@sha256:a38add811f7f139d6a385b22d283ad09ef305b8cf50382ef62f0ce690787f021
|
One or more libraries have failed to generate, please review PR description for a list of failed libraries. |
Sorry, something went wrong.
Summary of ChangesHello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the python-librarian-generator image, which is responsible for generating client libraries. The image update led to substantial changes within the google-cloud-firestore library, resulting in the removal of numerous files across its admin, bundle, and core v1 modules. Concurrently, a Python script used in the generation process was adjusted to align with new import paths for Firestore types. The PR description notes that generation failed for google-cloud-firestore, which likely explains the extensive removals and refactoring seen in the diff. Highlights
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here. Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Sorry, something went wrong.
There was a problem hiding this comment.
Code Review
The pull request updates the generator image and fixup scripts, but it also results in the catastrophic deletion of nearly all source files for the Firestore library (including firestore_v1, firestore_admin_v1, and firestore_bundle). This is consistent with the 'Generation failed' note in the PR description. Merging this would effectively remove the library from the repository. This PR should not be merged until the generation process is fixed and the source files are correctly restored.
I am having trouble creating individual review comments. Click here to see my feedback..librarian/state.yaml (1)
The update to this generator image hash is associated with a failed generation run that is deleting the entire Firestore library. This change should not be committed until the generation failure is resolved and the source code is correctly preserved.
google/cloud/firestore_v1/services/firestore/async_client.py (1-2310)
This file, along with the rest of the library's source code, is being deleted. This is a catastrophic change that appears to be an unintended consequence of the generation failure mentioned in the PR description. The PR should be blocked until the generator can successfully produce the library code.
Sorry, something went wrong.
feat: update image to us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:a38add811f7f139d6a385b22d283ad09ef305b8cf50382ef62f0ce690787f021
Generation failed for