This repository was archived by the owner on Mar 9, 2026. It is now read-only.
chore(revert): Revert "fix: get channel target for a gRPC request" - #1371
Merged
mukund-ananthu merged 3 commits intoMar 5, 2025
Merged
chore(revert): Revert "fix: get channel target for a gRPC request"#1371mukund-ananthu merged 3 commits into
mukund-ananthu merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This reverts commit 16ea766.
parthea
approved these changes
Mar 5, 2025
mukund-ananthu
approved these changes
Mar 5, 2025
mukund-ananthu
enabled auto-merge (squash)
March 5, 2025 21:30
parthea
approved these changes
Mar 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
2 more reviewersAssignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1339
The PR did not apply the fix as intended. Passing down an intercept channel, which is used to create another intercept channel requires us to call thunk twice i.e. to obtain the underlying grpc_channel, we'll need to do:
channel = client._transport.pull._thunk("")._thunk("")._channelInstead, we'll revert this change and then apply a follow up fix to obtain the underlying channel using the following way (until a more stable, long-term fix is determined):
channel = client._transport.pull._thunk("")._channel