FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

DO NOT MERGE: revert local changes to mypy by gcf-owl-bot[bot] · Pull Request #544 · googleapis/python-pubsub · GitHub

This repository was archived by the owner on Mar 9, 2026. It is now read-only.
/ python-pubsub Public archive

DO NOT MERGE: revert local changes to mypy - #544

Closed
gcf-owl-bot[bot] wants to merge 1 commit into
mainfrom
owl-bot-update-lock-74124fe59b8859f30143dcdea7b78300046d97de816dc53c0e381308a5f4f8bc
ConversationCommits (1)ChecksFiles changed
Closed

DO NOT MERGE: revert local changes to mypy#544
gcf-owl-bot[bot] wants to merge 1 commit into
mainfrom
owl-bot-update-lock-74124fe59b8859f30143dcdea7b78300046d97de816dc53c0e381308a5f4f8bc

Conversation

gcf-owl-bot Bot commented Dec 1, 2021

Copy link
Copy Markdown
Contributor

No description provided.

chore: keep beta version intact
52ddcb3 
Source-Link: googleapis/synthtool@6b5cee7
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:74124fe59b8859f30143dcdea7b78300046d97de816dc53c0e381308a5f4f8bc
gcf-owl-bot Bot requested review from a team December 1, 2021 17:14
trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 1, 2021
product-auto-label Bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Dec 1, 2021
google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 1, 2021
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 1, 2021
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 1, 2021
tseaver suggested changes Dec 1, 2021
View reviewed changes

tseaver left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@plamut This PR is undoing your work on mypy -- maybe you need to update owlbot.py?

tseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 1, 2021
tseaver changed the title chore: keep beta version intact DO NOT MERGE: revert local changes to mypy Dec 1, 2021

parthea commented Dec 2, 2021

Copy link
Copy Markdown
Contributor

Owlbot did not run on PR #542 . Moving forward, we could solve this issue by making owl bot a required check on all PRs. @plamut , please could you update owlbot.py ?

plamut commented Dec 2, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Ah, the noxfile is autogenerated in Pub/Sub, thanks for the notice (it's hand-written in BigQuery where I did the similar type hints task recently, which mislead me here).

Sure, I will add the necessary changes to owlbot.py.

Moving forward, we could solve this issue by making owl bot a required check on all PRs.

Now that the transition has been completed and the process is more or less stable, I think that would make sense. Contributors will then quickly see if any of their manual changes get overwritten by the bot.

plamut mentioned this pull request Dec 2, 2021
Closed

plamut commented Dec 2, 2021

Copy link
Copy Markdown
Contributor

Not relevant anymore, the changes that the bot wanted to undo here were persisted in #545

plamut closed this Dec 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
tseaver tseaver requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: pubsub Issues related to the googleapis/python-pubsub API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing. owl-bot-update-lock

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL