FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Docs: Mark exactly once delivery as preview by acocuzzo · Pull Request #656 · googleapis/python-pubsub · GitHub

This repository was archived by the owner on Mar 9, 2026. It is now read-only.
/ python-pubsub Public archive

Docs: Mark exactly once delivery as preview - #656

Closed
acocuzzo wants to merge 5 commits into
googleapis:mainfrom
acocuzzo:mark-eod-beta
Closed

Docs: Mark exactly once delivery as preview#656
acocuzzo wants to merge 5 commits into
googleapis:mainfrom
acocuzzo:mark-eod-beta

Conversation

Copy link
Copy Markdown
Contributor

Add comments to sample, as well as edit docstrings for ack, ack_with_response, modify ack deadline, and nack_with_response linking to exactly once delivery documentation.

Also swapped exactly once delivery NOT enabled descriptions to come first, so that the default case is shown first.

Fixes #617 🦕

acocuzzo requested a review from a team April 14, 2022 19:52
acocuzzo requested a review from a team as a code owner April 14, 2022 19:52
acocuzzo requested review from a team and m-strzelczyk April 14, 2022 19:52
product-auto-label Bot added the size: s Pull request size is small. label Apr 14, 2022

google-cla Bot commented Apr 14, 2022

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

product-auto-label Bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Apr 14, 2022
Anna Cocuzzo and others added 5 commits April 14, 2022 16:09
* Samples(test): Mark eod test super_flaky and extend timeout
* chore: use gapic-generator-python 0.65.1

PiperOrigin-RevId: 441524537

Source-Link: googleapis/googleapis@2a27391

Source-Link: googleapis/googleapis-gen@ab6756a
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWI2NzU2YTQ4Yzg5YjViY2I5ZmI3MzQ0M2NiOGU1NWQ1NzRmNDY0MyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
product-auto-label Bot added size: xl Pull request size is extra large. and removed size: s Pull request size is small. labels Apr 14, 2022
acocuzzo closed this Apr 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: pubsub Issues related to the googleapis/python-pubsub API. size: xl Pull request size is extra large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mark exactly once delivery as a preview feature

1 participant


Back | FazBrowse Home | New Git URL