FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore(spanner): Issue#1143 - Update dependency by bhatt4982 · Pull Request #1158 · googleapis/python-spanner · GitHub

This repository was archived by the owner on Jun 8, 2026. It is now read-only.
/ python-spanner Public archive

chore(spanner): Issue#1143 - Update dependency - #1158

Merged
harshachinta merged 16 commits into
googleapis:mainfrom
bhatt4982:Issue1143-update-dependencies
Aug 26, 2024
Merged

chore(spanner): Issue#1143 - Update dependency#1158
harshachinta merged 16 commits into
googleapis:mainfrom
bhatt4982:Issue1143-update-dependencies

Conversation

Copy link
Copy Markdown
Contributor

chore(spanner): Issue#1143 - Update dependency

  • Move grpc-interceptor to extras_required named testing

Fixes #1143 🦕

bhatt4982 requested review from a team July 8, 2024 04:10
product-auto-label Bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/python-spanner API. labels Jul 8, 2024
harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 9, 2024
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 9, 2024

harshachinta commented Jul 9, 2024
edited
Loading

Copy link
Copy Markdown
Contributor

@bhatt4982 The presubmits are failing since the tetsing dependency is not getting installed when installing depenedencies.
You will need to add this testing dependency as extra similar to tracing ones here. ex: pip install mypackage[tracing, testing]

  1. SYSTEM_TEST_EXTRAS: List[str] = [
  2. Please look at references to tracing and add testing at appropriate places
    session.install("-e", ".[tracing]", "-c", constraints_path)

This reference might help you understand
https://packaging.python.org/en/latest/tutorials/installing-packages/#installing-extras

- add dependency 'testing' for pretest
product-auto-label Bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jul 9, 2024
harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2024
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2024
- add dependency 'testing' for docs and docfx sessions
harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2024
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2024

Copy link
Copy Markdown
Contributor

@bhatt4982

  1. We will need to update owlbot.py https://github.com/googleapis/python-spanner/blob/112e74e6f15dc883dc347e82c890251c53a51a02/owlbot.py#L131C26-L131C33 to add testing dependency similar to tracing. Otherwise the automated PR might remove these changes,
  2. Can you fix the lint? Command: nox -s blacken

harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2024
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2024
harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 22, 2024
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 22, 2024
harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 29, 2024
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 29, 2024

Copy link
Copy Markdown
Contributor

@parthea Can you help with a quick review of this PR?

harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 31, 2024
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 31, 2024
harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 6, 2024
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 6, 2024
harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 22, 2024
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 22, 2024
harshachinta merged commit 44434aa into googleapis:main Aug 26, 2024
bhatt4982 deleted the Issue1143-update-dependencies branch August 27, 2024 06:08
rbarrette pushed a commit to rbarrette/python-spanner that referenced this pull request Sep 5, 2024
rbarrette pushed a commit to rbarrette/python-spanner that referenced this pull request Sep 5, 2024
rbarrette added a commit to rbarrette/python-spanner that referenced this pull request Sep 5, 2024
harshachinta added a commit that referenced this pull request Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/python-spanner API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

grpc-interceptor is listed as a dependency but is only used for testing utilities

4 participants


Back | FazBrowse Home | New Git URL