FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: Create a few code snippets as examples for using Spanner Graph in Python by bharadwajvr · Pull Request #1186 · googleapis/python-spanner · GitHub

This repository was archived by the owner on Jun 8, 2026. It is now read-only.
/ python-spanner Public archive

feat: Create a few code snippets as examples for using Spanner Graph in Python - #1186

Merged
harshachinta merged 12 commits into
googleapis:mainfrom
bharadwajvr:aeros
Aug 27, 2024
ConversationCommits (12)ChecksFiles changed
Merged

feat: Create a few code snippets as examples for using Spanner Graph in Python#1186
harshachinta merged 12 commits into
googleapis:mainfrom
bharadwajvr:aeros

Conversation

bharadwajvr commented Aug 9, 2024

Copy link
Copy Markdown
Contributor

Add a few code snippets to illustrate how to use Spanner Graph functionality in Python. These examples resemble other snippets for how various other Spanner features can be used.

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1185 🦕

bharadwajvr requested a review from a team as a code owner August 9, 2024 17:13
bharadwajvr requested review from a team and iennae August 9, 2024 17:13

snippet-bot Bot commented Aug 9, 2024 •
edited
Loading

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 9 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

product-auto-label Bot added the size: l Pull request size is large. label Aug 9, 2024
product-auto-label Bot added api: spanner Issues related to the googleapis/python-spanner API. samples Issues that are directly related to samples. labels Aug 9, 2024

bharadwajvr commented Aug 9, 2024

Copy link
Copy Markdown
Contributor Author

I did not find instructions for this in the authoring guide - how do I obtain code coverage information for the new code I've written? There is an ask in the description to verify that " Code coverage does not decrease (if any source code was changed)"

bharadwajvr commented Aug 15, 2024

Copy link
Copy Markdown
Contributor Author

Gentle ping.

bharadwajvr commented Aug 22, 2024

Copy link
Copy Markdown
Contributor Author

A reminder

harshachinta commented Aug 23, 2024

Copy link
Copy Markdown
Contributor

@bharadwajvr Thanks for the PR. Will review it early next week.

harshachinta commented Aug 23, 2024

Copy link
Copy Markdown
Contributor

I did not find instructions for this in the authoring guide - how do I obtain code coverage information for the new code I've written? There is an ask in the description to verify that " Code coverage does not decrease (if any source code was changed)"

Looking at the files changed, there is no source file changes in this PR. So this can be ignored.

bharadwajvr commented Aug 23, 2024

Copy link
Copy Markdown
Contributor Author

@bharadwajvr Thanks for the PR. Will review it early next week.

Thank you @harshachinta

harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 23, 2024
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 23, 2024
harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 26, 2024
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 26, 2024
harshachinta added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 26, 2024

harshachinta commented Aug 26, 2024

Copy link
Copy Markdown
Contributor

Adding Do not merge to check the presubmit build status before merging

harshachinta commented Aug 26, 2024

Copy link
Copy Markdown
Contributor

@bharadwajvr
Can you please fix the failing lint

bharadwajvr commented Aug 26, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@bharadwajvr Can you please fix the failing lint

Done. Local run succeeds. @harshachinta

$ flake8 --show-source --builtin=gettext --max-complexity=20 '--exclude=.nox,.cache,env,lib,generated_pb2,*_pb2.py,*_pb2_grpc.py' --ignore=E121,E123,E126,E203,E226,E24,E266,E501,E704,W503,W504,I202 --max-line-length=88
$

harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 27, 2024
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 27, 2024
harshachinta enabled auto-merge (squash) August 27, 2024 05:25
harshachinta removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 27, 2024
harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 27, 2024
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 27, 2024
harshachinta merged commit f886ebd into googleapis:main Aug 27, 2024
release-please Bot mentioned this pull request Aug 27, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

iennae Awaiting requested review from iennae iennae is a code owner automatically assigned from googleapis/python-samples-reviewers
1 more reviewer
harshachinta harshachinta approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

arpan14

Labels

api: spanner Issues related to the googleapis/python-spanner API. samples Issues that are directly related to samples. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create samples for Cloud Spanner Graph

4 participants

Back | FazBrowse Home | New Git URL