This repository was archived by the owner on Jun 8, 2026. It is now read-only.
fix(tracing): ensure nesting of Transaction.begin under commit + fix suggestions from feature review - #1287
Merged
harshachinta merged 3 commits intoJan 13, 2025
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
odeke-em
force-pushed
the
trace-update-cases-from-review
branch
from
e83b4af to
423e5bc
Compare
January 9, 2025 11:01
Comment thread
tests/system/test_observability_options.py
Outdated
Comment thread
tests/unit/test_database.py
Outdated
Comment thread
tests/unit/test_transaction.py
Outdated
Comment thread
tests/unit/test_transaction.py
Outdated
Comment thread
tests/unit/test_database.py
Outdated
odeke-em
force-pushed
the
trace-update-cases-from-review
branch
from
d32aab2 to
68cae9d
Compare
January 10, 2025 08:47
odeke-em
force-pushed
the
trace-update-cases-from-review
branch
from
68cae9d to
44b2862
Compare
January 10, 2025 09:03
…suggestions from feature review This change ensures that: * If a transaction was not yet begin, that if .commit() is invoked the resulting span hierarchy has .begin nested under .commit * We use "CloudSpanner.Transaction.execute_sql" instead of "CloudSpanner.Transaction.execute_streaming_sql" * If we have a tracer_provider that produces non-recordings spans, that it won't crash due to lacking `span._status` Fixes googleapis#1286
odeke-em
force-pushed
the
trace-update-cases-from-review
branch
2 times, most recently
from
8c27fc6 to
8ac5d36
Compare
January 10, 2025 12:32
Copy link
Copy Markdown
Contributor
Author
|
@harshachinta kindly please help me run the bots on this. Thank you. |
Sorry, something went wrong.
odeke-em
force-pushed
the
trace-update-cases-from-review
branch
from
8ac5d36 to
56f97a2
Compare
January 10, 2025 16:22
Copy link
Copy Markdown
Contributor
Author
|
@sakthivelmanii @harshachinta kindly help me run those bots once more. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Another re-run of the bots, kindly @harshachinta @sakthivelmanii @alkatrivedi |
Sorry, something went wrong.
harshachinta
approved these changes
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewerAssignees
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change ensures that:
Fixes #1286