This repository was archived by the owner on Jun 8, 2026. It is now read-only.
feat: Add Attempt, Operation and GFE Metrics - #1302
Merged
rahul2393 merged 8 commits intoMar 6, 2025
Merged
rahul2393 merged 8 commits into
rahul2393 merged 8 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
rahul2393
reviewed
Jan 29, 2025
rahul2393
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
As per offline discussion waiting for unit test to mock RPC failure and validate attempt_count>1
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@lszinv Build is failing INFO: pip is looking at multiple versions of google-cloud-spanner[tracing] to determine which version is compatible with other requirements. This could take a while. ERROR: Ignored the following versions that require a different python version: 0.44b0 Requires-Python >=3.8; 0.45b0 Requires-Python >=3.8; 0.46b0 Requires-Python >=3.8; 0.47b0 Requires-Python >=3.8; 0.48b0 Requires-Python >=3.8; 0.49b0 Requires-Python >=3.8; 0.49b1 Requires-Python >=3.8; 0.49b2 Requires-Python >=3.8; 0.50b0 Requires-Python >=3.8; 1.23.0 Requires-Python >=3.8; 1.24.0 Requires-Python >=3.8; 1.25.0 Requires-Python >=3.8; 1.26.0 Requires-Python >=3.8; 1.27.0 Requires-Python >=3.8; 1.28.0 Requires-Python >=3.8; 1.28.1 Requires-Python >=3.8; 1.28.2 Requires-Python >=3.8; 1.29.0 Requires-Python >=3.8; 5.0.0 Requires-Python >=3.8; 5.0.1 Requires-Python >=3.8; 5.1.0 Requires-Python >=3.9 ERROR: Could not find a version that satisfies the requirement mmh3>=5.0.1 (from google-cloud-spanner[tracing]) (from versions: 2.0, 2.2, 2.3, 2.3.1, 2.4, 2.5, 2.5.1, 3.0.0, 3.1.0, 4.0.0, 4.0.1, 4.1.0) ERROR: No matching distribution found for mmh3>=5.0.1 nox > Session unit-3.7(protobuf_implementation='python') failed. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Investigating the 3.7 test failure. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Ignore the last commit. Will be pushing a new one to fix the test without disabling it. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Apologies, forgot to run the mockserver tests with the last change. I've fixed the test failures. |
Sorry, something went wrong.
rahul2393
approved these changes
Feb 11, 2025
This was referenced Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewerAssignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of the MetricTracer and SpannerMetricFactory, a specific instance of the MetricFactory that populates the factory with metadata specific to the Python Spanner Client.
The Implemented metrics: