FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: Remove unused files by parthea · Pull Request #1319 · googleapis/python-spanner · GitHub

This repository was archived by the owner on Jun 8, 2026. It is now read-only.
/ python-spanner Public archive

chore: Remove unused files - #1319

Merged
parthea merged 2 commits into
mainfrom
remove-unused-files
Mar 5, 2025
Merged

parthea merged 2 commits into
mainfrom
remove-unused-files

Conversation

parthea commented Mar 5, 2025

Copy link
Copy Markdown
Contributor

parthea requested review from a team March 5, 2025 11:07
product-auto-label Bot added size: xl Pull request size is extra large. api: spanner Issues related to the googleapis/python-spanner API. labels Mar 5, 2025
parthea changed the title Remove unused files chore: Remove unused files Mar 5, 2025
parthea merged commit d025867 into main Mar 5, 2025
parthea deleted the remove-unused-files branch March 5, 2025 16:00
waiho-gumloop added a commit to waiho-gumloop/python-spanner that referenced this pull request Mar 25, 2026
trace_call() wraps every Spanner operation with a bare MetricsCapture()
that creates a MetricsTracer without project_id or instance_id. Since
every caller of trace_call already provides its own MetricsCapture with
resource_info, this inner one is redundant.

The redundant tracer records operation metrics with incomplete resource
labels on every operation. Because OpenTelemetry uses cumulative
aggregation, these orphan data points persist for the process lifetime
and get re-exported every 60 seconds. Cloud Monitoring rejects them
with INVALID_ARGUMENT (missing instance_id), producing repeated error
logs.

Removing the bare MetricsCapture from trace_call eliminates the orphan
metric data points entirely. Callers continue to provide their own
MetricsCapture(resource_info) with correct labels.

Fixes: googleapis#1319
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/python-spanner API. size: xl Pull request size is extra large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL