This repository was archived by the owner on Jun 8, 2026. It is now read-only.
feat: add cloud.region, request_tag and transaction_tag in span attributes - #1449
Merged
sinhasubham merged 8 commits intoNov 12, 2025
Merged
feat: add cloud.region, request_tag and transaction_tag in span attributes#1449sinhasubham merged 8 commits into
sinhasubham merged 8 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
sinhasubham
force-pushed
the
fix/span-attributes
branch
from
b5ca757 to
af65849
Compare
October 27, 2025 06:52
sinhasubham
force-pushed
the
fix/span-attributes
branch
from
f5bed57 to
1bd0a2c
Compare
October 28, 2025 09:01
sinhasubham
force-pushed
the
fix/span-attributes
branch
from
15f395e to
6059b9b
Compare
October 28, 2025 11:06
Comment thread
google/cloud/spanner_v1/_opentelemetry_tracing.py
Outdated
| "enable_end_to_end_tracing", enable_end_to_end_tracing | ||
| ) | ||
| db_name = observability_options.get("db_name", db_name) | ||
| cloud_region = observability_options.get("cloud_region", cloud_region) |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
What is the use of this ?
IMU, observability_options is something which customers can set and does not have cloud_region property.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
this line is not required as _get_cloud_region is overriding the value in next line. Removed
Sorry, something went wrong.
Comment thread
google/cloud/spanner_v1/_opentelemetry_tracing.py
Comment thread
google/cloud/spanner_v1/_opentelemetry_tracing.py
Outdated
| if "request_options" in attributes: | ||
| request_options = attributes.pop("request_options") | ||
| if request_options and request_options.request_tag: | ||
| attributes["spanner.request_tag"] = request_options.request_tag |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Please use attribute name as request.tag and transaction.tag to be consistent with other languages.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Do we also need the same for transaction.tag
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Refactored to request.tag. transaction tag is already transaction.tag so it shouldn't need any change right?
Sorry, something went wrong.
| # Overwrite the requests timeout for the detector. | ||
| # This is necessary as the client will wait the full timeout if the | ||
| # code is not run in a GCP environment, with the location endpoints available. | ||
| gcp_resource_detector._TIMEOUT_SEC = 0.2 |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Please check if we need this timeout in the new code after refactoring. Currently get region does not have any timeout
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Yes got missed while moving the logic to helper. Added back
Sorry, something went wrong.
sinhasubham
force-pushed
the
fix/span-attributes
branch
from
6059b9b to
e0a2fb9
Compare
November 11, 2025 10:42
sinhasubham
force-pushed
the
fix/span-attributes
branch
from
e0a2fb9 to
f3bf074
Compare
November 11, 2025 10:42
sinhasubham
force-pushed
the
fix/span-attributes
branch
from
9d2d9e0 to
2ff6bf1
Compare
November 11, 2025 18:24
surbhigarg92
approved these changes
Nov 12, 2025
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Dec 10, 2025
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v1.0.0 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:8e2c32496077054105bd06c54a59d6a6694287bc053588e24debe6da6920ad91 <details><summary>google-cloud-spanner: 3.60.0</summary> ## [3.60.0](https://togithub.com/googleapis/python-spanner/compare/v3.59.0...v3.60.0) (2025-12-10) ### Features * make built-in metrics enabled by default (#1459) ([64aebe7](https://togithub.com/googleapis/python-spanner/commit/64aebe7e)) * Exposing AutoscalingConfig in InstancePartition ([8b6f154](https://togithub.com/googleapis/python-spanner/commit/8b6f1540)) * add support for experimental host (#1452) ([9535e5e](https://togithub.com/googleapis/python-spanner/commit/9535e5e0)) * enable OpenTelemetry metrics and tracing by default (#1410) ([bb5095d](https://togithub.com/googleapis/python-spanner/commit/bb5095df)) * add cloud.region, request_tag and transaction_tag in span attributes (#1449) ([d37fb80](https://togithub.com/googleapis/python-spanner/commit/d37fb80a)) * Add QueryAdvisorResult for query plan (PiperOrigin-RevId: 832425466) ([e08260f](https://togithub.com/googleapis/python-spanner/commit/e08260fe)) * Add Send and Ack mutations for Queues (PiperOrigin-RevId: 832425466) ([e08260f](https://togithub.com/googleapis/python-spanner/commit/e08260fe)) * Add Spanner location API (#1457) (PiperOrigin-RevId: 833474957) ([e08260f](https://togithub.com/googleapis/python-spanner/commit/e08260fe)) ### Bug Fixes * Deprecate credentials_file argument ([8b6f154](https://togithub.com/googleapis/python-spanner/commit/8b6f1540)) * configure keepAlive time for gRPC TCP connections (#1448) ([efb2833](https://togithub.com/googleapis/python-spanner/commit/efb2833e)) * Provide Spanner Option to disable metrics (#1460) ([f1ebc43](https://togithub.com/googleapis/python-spanner/commit/f1ebc43b)) ### Documentation * Update description for the BatchCreateSessionsRequest and Session (PiperOrigin-RevId: 832425466) ([e08260f](https://togithub.com/googleapis/python-spanner/commit/e08260fe)) * Update description for the IsolationLevel (PiperOrigin-RevId: 832425466) ([e08260f](https://togithub.com/googleapis/python-spanner/commit/e08260fe)) </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewerAssignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change enhances observability by introducing these new features:
Cloud Region Attribute: The cloud.region attribute is now added to all OpenTelemetry spans generated by the Spanner client. This provides better geographical context for traces, aiding in performance analysis and debugging across different regions.
Transaction Tag: The transaction_tag set on a Transaction object is now correctly propagated and included in the Commit request. This allows for better end-to-end traceability of transactions.
Request Tag: This introduces support for request_tag on individual Spanner operations like read, execute_sql, and execute_update. When a request_tag is provided in the request_options, it is now added as a spanner.request_tag attribute to the corresponding OpenTelemetry span. This allows for more granular tracing and debugging of specific requests within a transaction or a snapshot.