FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: librarian generate pull request: 20260325T173440Z by parthea · Pull Request #1529 · googleapis/python-spanner · GitHub

This repository was archived by the owner on Jun 8, 2026. It is now read-only.
/ python-spanner Public archive

chore: librarian generate pull request: 20260325T173440Z - #1529

Merged
parthea merged 2 commits into
mainfrom
librarian-20260325T173440Z
Mar 25, 2026
ConversationCommits (2)ChecksFiles changed
Merged

chore: librarian generate pull request: 20260325T173440Z#1529
parthea merged 2 commits into
mainfrom
librarian-20260325T173440Z

Conversation

parthea commented Mar 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR created by the Librarian CLI to generate Cloud Client Libraries code from protos.

BEGIN_COMMIT

BEGIN_NESTED_COMMIT
docs: A comment for field routing_hint in messages .google.spanner.v1.ResultSet and .google.spanner.v1.PartialResultSet are changed

PiperOrigin-RevId: 878019893
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@5c9602db
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
docs: A comment in message .google.spanner.v1.TransactionOptions.ReadWrite.ReadLockMode is changed

PiperOrigin-RevId: 878019893
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@5c9602db
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
feat: include cache updates and routing hint into BeginTransaction and Commit request/response respectively

PiperOrigin-RevId: 878019893
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@5c9602db
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
docs: A comment for field params in message .google.spanner.v1.PartitionQueryRequest is changed

PiperOrigin-RevId: 865546011
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@8d30990f
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
feat: include cache updates into the ResultSet response

PiperOrigin-RevId: 865546011
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@8d30990f
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
docs: A comment for field transaction_tag in message .google.spanner.v1.RequestOptions is changed

PiperOrigin-RevId: 865546011
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@8d30990f
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
docs: A comment for field param_types in message .google.spanner.v1.PartitionQueryRequest is changed

PiperOrigin-RevId: 865546011
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@8d30990f
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
docs: A comment for field commit_timestamp in message .google.spanner.v1.BatchWriteResponse is changed

PiperOrigin-RevId: 865546011
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@8d30990f
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
chore: adjust initial_poll_delay for CreateDatabase and UpdateDatabaseDdl LRO operations

PiperOrigin-RevId: 853884590
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@136a2c43
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
feat: add a ClientContext field to Spanner requests

PiperOrigin-RevId: 853323071
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@211d22fa
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
feat: add Secure Parameters to the ClientContext

PiperOrigin-RevId: 853323071
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@211d22fa
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
feat: Exposing total CPU related fields in AutoscalingConfig

PiperOrigin-RevId: 845819318
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@6e20492a
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
docs: Update high_priority_cpu_utilization_percent in AutoscalingConfig to be Optional and clarify its behavior when not specified

PiperOrigin-RevId: 845819318
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@6e20492a
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
docs: minor update for Spanner Location API

PiperOrigin-RevId: 834841888
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@ded7ed1e
END_NESTED_COMMIT

END_COMMIT

This pull request is generated with proto changes between
googleapis/googleapis@a17b84ad
(exclusive) and
googleapis/googleapis@5c9602db
(inclusive).

Librarian Version: v1.0.2-0.20260309131826-42ac5c451239
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:b8058df4c45e9a6e07f6b4d65b458d0d059241dd34c814f151c8bf6b89211209

Fixes #1527

This PR also moves ClientContext under RequestOptions as per #1527 (comment). ClientContext was added in #1499 but the feature has not been released yet so it is safe to move.

parthea requested review from a team as code owners March 25, 2026 17:34
product-auto-label Bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/python-spanner API. labels Mar 25, 2026

gemini-code-assist Bot commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates several updates to the Google Cloud Spanner client library, primarily focusing on API enhancements for location awareness, improved autoscaling configurations, and refined client context handling. It also includes significant updates to the testing and code generation infrastructure, ensuring better support for asynchronous operations and clearer documentation for developers.

Highlights

  • Spanner API Enhancements: Introduced new fields for location-aware requests and cache updates across several Spanner API messages, including BeginTransactionRequest, CommitRequest, CommitResponse, ResultSet, and Transaction.
  • Autoscaling Configuration Updates: Expanded Spanner instance autoscaling capabilities by adding total_cpu_utilization_percent to AutoscalingTargets and new options to disable high-priority and total CPU autoscaling in AutoscalingConfigOverrides.
  • ClientContext Refactoring: The ClientContext message has been refactored and moved as a nested message within RequestOptions, streamlining its usage and definition.
  • Testing Infrastructure Improvements: Updated the noxfile.py to enhance system test execution, including support for asynchronous tests and a new generate session for regenerating synchronous code.
  • Documentation Clarifications: Numerous documentation comments were updated across the Spanner API, providing clearer explanations for fields such as ReadLockMode, transaction_tag, routing_hint, params, param_types, and commit_timestamp.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist Bot reviewed Mar 25, 2026
View reviewed changes

gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code Review

This pull request introduces significant enhancements and refactorings to the Spanner client library. Key changes include expanding Spanner instance autoscaling capabilities with total_cpu_utilization_percent and related override options, and improving performance through location awareness by adding routing_hint to BeginTransactionRequest and CommitRequest, and cache_update to CommitResponse, ResultSet, and Transaction objects. The ClientContext class has been refactored to be a nested class within RequestOptions, with all references updated across the codebase and tests. Additionally, the noxfile.py has been updated to support asynchronous system tests, refine unit test argument handling, and introduce a new generate session for cross-sync code generation. Docstrings have been clarified, and new dependencies related to google-auth have been added. There is no feedback to provide as no review comments were given.

parthea mentioned this pull request Mar 25, 2026
Closed
aseering approved these changes Mar 25, 2026
View reviewed changes

aseering left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Reviewing regarding ClientContext: Because the corresponding feature hasn't launched yet (neither Client support nor in the backend), I think it's fine to make changes like moving it to under RequestContext. I don't have any particular objection to making this specific change, as long as doing so aligns us with how other classes are handled and is representative of a coding pattern that we'd be planning to stick with going forward.

parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 25, 2026

parthea commented Mar 25, 2026

Copy link
Copy Markdown
Contributor Author

Adding do not merge until all pending checks pass

parthea mentioned this pull request Mar 25, 2026
Closed
parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 25, 2026

parthea commented Mar 25, 2026

Copy link
Copy Markdown
Contributor Author

The failure in Kokoro - Test: Integration with Regular Sessions is for Python 3.9 which is no longer supported in CI. I'll open a separate PR to fix that.

nox > * unit-3.9(protobuf_implementation='python'): failed
nox > * unit-3.9(protobuf_implementation='upb'): failed
nox > * unit-3.9(protobuf_implementation='cpp'): failed

parthea merged commit 85443e4 into main Mar 25, 2026
24 of 25 checks passed
parthea deleted the librarian-20260325T173440Z branch March 25, 2026 18:40
parthea mentioned this pull request Mar 25, 2026
Merged
parthea added a commit that referenced this pull request Mar 25, 2026
tests: use Python 3.10 in Integration with Regular Sessions presubm…
9494019 
…it (#1530)

In #1529, Presubmit
`Kokoro - Test: Integration with Regular Sessions` failed because Python
3.9 is no longer supported in the Python Kokoro CI. This PR fixes the
presubmit by using 3.10 instead.
chalmerlowe pushed a commit to googleapis/google-cloud-python that referenced this pull request Mar 26, 2026
tests: use Python 3.10 in Integration with Regular Sessions presubm…
af0b5b9 
…it (#1530)

In googleapis/python-spanner#1529, Presubmit
`Kokoro - Test: Integration with Regular Sessions` failed because Python
3.9 is no longer supported in the Python Kokoro CI. This PR fixes the
presubmit by using 3.10 instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers
gemini-code-assist[bot] gemini-code-assist[bot] left review comments
aseering aseering approved these changes
olavloite olavloite approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

aseering

olavloite

bhatt4982

Labels

api: spanner Issues related to the googleapis/python-spanner API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move ClientContext under RequestOptions

4 participants

Back | FazBrowse Home | New Git URL