This repository was archived by the owner on Jun 8, 2026. It is now read-only.
feat(dbapi): add aborted transactions retry support - #168
Merged
c24t merged 5 commits intoNov 23, 2020
Merged
c24t merged 5 commits into
c24t merged 5 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
IlyaFaer
marked this pull request as ready for review
November 13, 2020 07:38
c24t
reviewed
Nov 17, 2020
c24t
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM with a few minor comments. I checked that this matches the diffs from googleapis/python-spanner-django#544 and googleapis/python-spanner-django#543, see the comments there for more info.
Sorry, something went wrong.
Comment thread
google/cloud/spanner_dbapi/checksum.py
Outdated
Comment thread
google/cloud/spanner_dbapi/connection.py
Comment thread
tests/system/test_system.py
Outdated
Comment thread
tests/unit/spanner_dbapi/test_checksum.py
| @@ -0,0 +1,63 @@ | |||
| # Copyright 2020 Google LLC | |||
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Another packaging thing to consider: we might want to move all the DBAPI tests under google/cloud/spanner_dbapi/tests/ so the code and tests live in the same package.
Sorry, something went wrong.
larkee
approved these changes
Nov 23, 2020
larkee
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM 👍
Sorry, something went wrong.
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Nov 30, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [2.1.0](https://www.github.com/googleapis/python-spanner/compare/v2.0.0...v2.1.0) (2020-11-24) ### Features * **dbapi:** add aborted transactions retry support ([#168](https://www.github.com/googleapis/python-spanner/issues/168)) ([d59d502](https://www.github.com/googleapis/python-spanner/commit/d59d502590f618c8b13920ae05ab11add78315b5)), closes [#34](https://www.github.com/googleapis/python-spanner/issues/34) [googleapis/python-spanner-django#544](https://www.github.com/googleapis/python-spanner-django/issues/544) * remove adding a dummy WHERE clause into UPDATE and DELETE statements ([#169](https://www.github.com/googleapis/python-spanner/issues/169)) ([7f4d478](https://www.github.com/googleapis/python-spanner/commit/7f4d478fd9812c965cdb185c52aa9a8c9e599bed)) ### Bug Fixes * Add sqlparse dependency ([#171](https://www.github.com/googleapis/python-spanner/issues/171)) ([e801a2e](https://www.github.com/googleapis/python-spanner/commit/e801a2e014fcff66a69cb9da83abedb218cda2ab)) ### Reverts * Revert "test: unskip list_backup_operations sample test (#170)" (#174) ([6053f4a](https://www.github.com/googleapis/python-spanner/commit/6053f4ab0fc647a9cfc181e16c246141483c2397)), closes [#170](https://www.github.com/googleapis/python-spanner/issues/170) [#174](https://www.github.com/googleapis/python-spanner/issues/174) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
This was referenced Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34.
See googleapis/python-spanner-django#544.