This repository was archived by the owner on Jun 8, 2026. It is now read-only.
test: improve cleanup to prevent RESOURCE_EXHAUSTED error - #195
Merged
larkee merged 4 commits intoDec 17, 2020
Merged
larkee merged 4 commits into
larkee merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
larkee
marked this pull request as ready for review
December 16, 2020 02:48
IlyaFaer
approved these changes
Dec 16, 2020
IlyaFaer
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
Looks okay to me. Thanks!
Sorry, something went wrong.
c24t
approved these changes
Dec 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, there is no guarantee that the resources created during the system tests are cleaned up as the jobs running the tests can be cancelled before finishing. This means that over time the testing project runs out of resources due to undeleted instances which causes all system tests runs to fail.
This PR adds labels to the instance created for the test so that any instance created for a test that is older than an hour can be identified and deleted. This will keep the testing project from running out of resources over time.