This repository was archived by the owner on Jun 8, 2026. It is now read-only.
fix(db_api): use correct connection attribute when handling Aborted errors - #228
Merged
larkee merged 1 commit intoFeb 15, 2021
Merged
larkee merged 1 commit into
larkee merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thank you for making this PR! Improved test coverage is always appreciated. Are there plans to improve the coverage for google/cloud/spanner_dbapi/utils.py and google/cloud/spanner_dbapi/connection.py as well? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Yes, I will open other PR soon. |
Sorry, something went wrong.
larkee
approved these changes
Feb 9, 2021
larkee
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks again!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #225
This PR include error related unit tests to raise the coverage of "DB_API".