FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(db_api): update parse_util output for homogeneous statements by HemangChothani · Pull Request #233 · googleapis/python-spanner · GitHub

This repository was archived by the owner on Jun 8, 2026. It is now read-only.
/ python-spanner Public archive

fix(db_api): update parse_util output for homogeneous statements - #233

Merged
larkee merged 1 commit into
googleapis:masterfrom
MaxxleLLC:spanner_issue_232
Feb 18, 2021
ConversationCommits (1)ChecksFiles changed
Merged

fix(db_api): update parse_util output for homogeneous statements#233
larkee merged 1 commit into
googleapis:masterfrom
MaxxleLLC:spanner_issue_232

Conversation

HemangChothani commented Feb 11, 2021

Copy link
Copy Markdown
Contributor

Fixes #232

HemangChothani requested review from a team, c24t and larkee February 11, 2021 12:17
google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 11, 2021
product-auto-label Bot added the api: spanner Issues related to the googleapis/python-spanner API. label Feb 11, 2021
larkee reviewed Feb 15, 2021
View reviewed changes
Comment thread google/cloud/spanner_dbapi/parse_utils.py
"table": match.group("table_name"),
"columns": columns,
"values": rows_list,
}

larkee Feb 15, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Is this a breaking change?

HemangChothani Feb 15, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nope i think.

larkee Feb 15, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Oh, I see. The docstring correctly documents this behavior. In that case, I don't think this is a breaking change since it is fixing it to match the documented behavior.

larkee commented Feb 15, 2021

Copy link
Copy Markdown
Contributor

Please update the title to be more descriptive i.e. fix: update parse_util output for homogeneous statements

The PR title will be used in the release notes.

larkee mentioned this pull request Feb 15, 2021
Merged
HemangChothani changed the title fix: fix execute insert for homogeneous statement fix: update parse_util output for homogeneous statements Feb 15, 2021
larkee reviewed Feb 15, 2021
View reviewed changes

larkee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM once the title is updated

Comment thread google/cloud/spanner_dbapi/parse_utils.py
"table": match.group("table_name"),
"columns": columns,
"values": rows_list,
}

larkee Feb 15, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Oh, I see. The docstring correctly documents this behavior. In that case, I don't think this is a breaking change since it is fixing it to match the documented behavior.

HemangChothani commented Feb 15, 2021

Copy link
Copy Markdown
Contributor Author

LGTM once the title is updated

I have changed the title.

larkee changed the title fix: update parse_util output for homogeneous statements fix(db_api): update parse_util output for homogeneous statements Feb 16, 2021
larkee merged commit 36b12a7 into googleapis:master Feb 18, 2021
IlyaFaer pushed a commit to MaxxleLLC/python-spanner that referenced this pull request Mar 22, 2021
fix: revert googleapis#233
21a82cb
IlyaFaer mentioned this pull request Mar 22, 2021
Merged
larkee pushed a commit that referenced this pull request Mar 24, 2021
fix(db_api): revert Mutations API usage (#285)
e5d4901 
* fix: revert #233

* update docstrings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

c24t Awaiting requested review from c24t
1 more reviewer
larkee larkee approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

db_api: parse_insert method doesn't work as expected

2 participants

Back | FazBrowse Home | New Git URL