This repository was archived by the owner on Jun 8, 2026. It is now read-only.
chore: changing default region to us-west1 - #640
Merged
vi3k6i5 merged 9 commits intoDec 21, 2021
Merged
vi3k6i5 merged 9 commits into
vi3k6i5 merged 9 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
asthamohta
force-pushed
the
change-region
branch
from
3db1f56 to
a600b67
Compare
November 11, 2021 13:40
asthamohta
marked this pull request as ready for review
November 11, 2021 20:07
larkee
approved these changes
Nov 15, 2021
larkee
suggested changes
Nov 15, 2021
larkee
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
The backup tests also use an additional instance with a different config:
We should probably prevent that one from choosing us-central1 for now as well.
We should also make this change for the samples:
https://github.com/googleapis/python-spanner/blob/main/samples/samples/conftest.py#L90
Sorry, something went wrong.
asthamohta
force-pushed
the
change-region
branch
2 times, most recently
from
76fd990 to
a518d2b
Compare
November 16, 2021 05:37
asthamohta
force-pushed
the
change-region
branch
from
f43cbd2 to
415beca
Compare
November 16, 2021 12:01
vi3k6i5
approved these changes
Dec 21, 2021
vi3k6i5
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
larkee
approved these changes
Dec 21, 2021
vi3k6i5
pushed a commit
to vi3k6i5/python-spanner
that referenced
this pull request
Mar 29, 2022
* chore: changing default region to us-west1 * chore(deps): update all dependencies (googleapis#602) * chore: add default_version and codeowner_team to .repo-metadata.json (googleapis#641) * feat(db_api): support stale reads (googleapis#584) * feat: removing changes from samples * chore: change region * fix: fix in sample list-backups Co-authored-by: WhiteSource Renovate <bot@renovateapp.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com> Co-authored-by: Ilya Gurov <ilya.faer@mail.ru> Co-authored-by: larkee <31196561+larkee@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.