This repository was archived by the owner on Jun 8, 2026. It is now read-only.
feat: support request options in !autocommit mode - #838
Merged
IlyaFaer merged 2 commits intoOct 13, 2022
Merged
IlyaFaer merged 2 commits into
IlyaFaer merged 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
IlyaFaer
commented
Oct 7, 2022
Comment thread
google/cloud/spanner_dbapi/connection.py
|
|
||
| req_opts = RequestOptions(priority=self.request_priority) | ||
| self.request_priority = None | ||
| return req_opts |
Copy link
Copy Markdown
Author
There was a problem hiding this comment.
Request options are used only for next one request
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Is there a reason for this?
Sorry, something went wrong.
Copy link
Copy Markdown
Author
There was a problem hiding this comment.
Spanner is designed this way, otherwise there is no sense in request options.
Let's say there is a request priority. If it'll be set for a connection/session, than all the requests will have the same priority. It's technically the same that not setting priority at all.
Sorry, something went wrong.
IlyaFaer
marked this pull request as ready for review
October 7, 2022 08:32
asthamohta
approved these changes
Oct 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards googleapis/python-spanner-sqlalchemy#248