This repository was archived by the owner on Jun 8, 2026. It is now read-only.
feat: add support for updateDatabase in Cloud Spanner - #914
Merged
rajatbhatta merged 14 commits intoMay 16, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
grace223
approved these changes
Mar 18, 2023
Comment thread
google/cloud/spanner_v1/database.py
| from google.iam.v1 import options_pb2 | ||
| from google.protobuf.field_mask_pb2 import FieldMask | ||
|
|
||
| from google.cloud.spanner_admin_database_v1 import CreateDatabaseRequest |
Copy link
Copy Markdown
There was a problem hiding this comment.
Thanks
Sorry, something went wrong.
Comment thread
tests/unit/test_database.py
| import mock | ||
| from google.api_core import gapic_v1 | ||
| from google.cloud.spanner_admin_database_v1 import Database as DatabasePB | ||
| from google.cloud.spanner_v1.param_types import INT64 |
Copy link
Copy Markdown
There was a problem hiding this comment.
Thanks
Sorry, something went wrong.
Copy link
Copy Markdown
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
Sorry, something went wrong.
aayushimalik
force-pushed
the
drop-database-protection
branch
from
9ca2103 to
e4163d0
Compare
March 21, 2023 10:26
rajatbhatta
reviewed
Apr 4, 2023
Comment thread
google/cloud/spanner_v1/database.py
Outdated
asthamohta
reviewed
Apr 4, 2023
Comment thread
google/cloud/spanner_v1/database.py
Outdated
asthamohta
reviewed
Apr 4, 2023
Comment thread
google/cloud/spanner_v1/database.py
Outdated
asthamohta
reviewed
Apr 21, 2023
Comment thread
google/cloud/spanner_v1/database.py
| self._database_dialect = database_dialect | ||
| self._database_role = database_role | ||
| self._enable_drop_protection = enable_drop_protection | ||
| self._reconciling = False |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I can't see any place where this value is updated?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
This is updated at line 359 of this file, using the property setter.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I am referring to reconciling
Sorry, something went wrong.
asthamohta
reviewed
Apr 21, 2023
Comment thread
google/cloud/spanner_v1/database.py
asthamohta
reviewed
Apr 21, 2023
Comment thread
tests/system/test_database_api.py
Outdated
asthamohta
approved these changes
Apr 26, 2023
…p-database-protection # Conflicts: # google/cloud/spanner_v1/database.py
rajatbhatta
enabled auto-merge (squash)
May 16, 2023 06:24
Copy link
Copy Markdown
Contributor
|
Added samples from #917 to here (for single merge). Both PRs are approved. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.