FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: cursor must detect if the parent connection is closed by IlyaFaer · Pull Request #463 · googleapis/python-spanner-django · GitHub

This repository was archived by the owner on Jun 8, 2026. It is now read-only.

feat: cursor must detect if the parent connection is closed - #463

Merged
c24t merged 17 commits into
googleapis:masterfrom
MaxxleLLC:is_closed_attribute
Sep 1, 2020
Merged

c24t merged 17 commits into
googleapis:masterfrom
MaxxleLLC:is_closed_attribute

Conversation

Copy link
Copy Markdown

Closes #461

IlyaFaer added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: spanner Issues related to the googleapis/python-spanner-django API. labels Aug 24, 2020
google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 24, 2020

Copy link
Copy Markdown
Author

This PR is based on changes from connect() refactoring changes, so it should be merged after "connect() refactoring" PR

IlyaFaer marked this pull request as ready for review August 24, 2020 09:58
IlyaFaer requested a review from c24t August 24, 2020 09:58

c24t left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks great, I'll review again after #462 gets merged.

c24t left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Only minor comments, but @IlyaFaer I'll wait until you respond to approve so we don't automatically merge this before it's ready.

Comment thread spanner_dbapi/cursor.py Outdated
Comment thread spanner_dbapi/cursor.py

c24t commented Aug 28, 2020

Copy link
Copy Markdown
Contributor

Seeing more of these in CI:

panic: rpc error: code = ResourceExhausted desc = Project 1065521786570 cannot add 1 nodes in region us-west1.

Hopefully to be fixed in #471.

IlyaFaer left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I've added few more docstrings/renaming changes

Comment thread spanner_dbapi/cursor.py Outdated
c24t merged commit 6028f88 into googleapis:master Sep 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/python-spanner-django API. cla: yes This human has signed the Contributor License Agreement. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Connection.close() doesn't close cursors

2 participants


Back | FazBrowse Home | New Git URL