FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: Stage 6 of `nox` implementation - enabling system tests by mf2199 · Pull Request #480 · googleapis/python-spanner-django · GitHub

This repository was archived by the owner on Jun 8, 2026. It is now read-only.
/ python-spanner-django Public archive

feat: Stage 6 of nox implementation - enabling system tests - #480

Merged
c24t merged 6 commits into
googleapis:masterfrom
MaxxleLLC:nox-6
Sep 8, 2020
ConversationCommits (6)ChecksFiles changed
Merged

feat: Stage 6 of nox implementation - enabling system tests#480
c24t merged 6 commits into
googleapis:masterfrom
MaxxleLLC:nox-6

Conversation

mf2199 commented Aug 31, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

As suggested in #466 , this represents the last item of the recommended list aimed to implement nox testing automation in multiple steps.

Change list:

  1. Added a copy of a common test_utils package directory;
  2. Added system test session to Nox configuration;
  3. New tests/system/test_system.py template file;
  4. Some updates to to .gitignore file.

A dummy test method inside the template file is necessary to avoid an exit code 5 error, that is when no tests get collected.

Session test log:

nox > Running session system
nox > Creating virtual environment (virtualenv) using python.exe in .nox\system
nox > pip install mock pytest
nox > pip install -e .
nox > pip install -e test_utils
nox > py.test --quiet tests\system
.                                                                                                                                                                                                                                [100%]
1 passed in 0.03s
nox > Session system was successful.

Towards #474.

google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 31, 2020
mf2199 changed the title feat: Stage 5 of nox implementation - enabling system tests feat: Stage 6 of nox implementation - enabling system tests Aug 31, 2020
mf2199 added api: spanner Issues related to the googleapis/python-spanner-django API. type: process A process-related concern. May include testing, release, or the like. labels Aug 31, 2020
mf2199 marked this pull request as ready for review August 31, 2020 22:01
mf2199 requested a review from c24t August 31, 2020 22:01
AVaksman added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 3, 2020
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 3, 2020
busunkim96 reviewed Sep 3, 2020
View reviewed changes
Comment thread noxfile.py Outdated
# virtualenv's dist-packages.
session.install("mock", "pytest")
session.install("-e", ".")
session.install("-e", "test_utils")

busunkim96 Sep 3, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

If any of the system tests need the contents of test_utils, you can install it through pip.

It might not be necessary though (there's not too much in it (https://github.com/googleapis/python-test-utils/tree/master/test_utils) at this point.

pip install google-cloud-testutils

mf2199 Sep 4, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@busunkim96 👍 Agreed. This way used to be prevalent across other products and still exists in Spanner, Bigtable, and possibly some others. Would it be a good idea to update those as well?

c24t reviewed Sep 8, 2020
View reviewed changes
Comment thread noxfile.py Outdated
c24t merged commit 94ba284 into googleapis:master Sep 8, 2020
This was referenced Sep 10, 2020
Closed
Closed
c24t pushed a commit that referenced this pull request Sep 15, 2020
feat: Stage 6 of nox implementation - enabling system tests (#480)
dc73bf6 
Add googleapis/python-test-utils and system test stub
This was referenced Apr 17, 2024
Closed
Closed
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
busunkim96 busunkim96 left review comments
c24t c24t approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/python-spanner-django API. cla: yes This human has signed the Contributor License Agreement. type: process A process-related concern. May include testing, release, or the like.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL