This repository was archived by the owner on Jun 8, 2026. It is now read-only.
feat: added unit test with coverage of 68 % - #611
Merged
c24t merged 12 commits intoMay 17, 2021
Merged
c24t merged 12 commits into
c24t merged 12 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
chore: add a Code of Conduct (googleapis#604)
fix: lint_setup_py was failing in Kokoro is now fixed (googleapis#607)
larkee
reviewed
Apr 23, 2021
Comment thread
tests/unit/django_spanner/models.py
Comment thread
tests/unit/django_spanner/models.py
Outdated
vi3k6i5
force-pushed
the
unit_tests_2
branch
2 times, most recently
from
b0f0e88 to
2391801
Compare
April 24, 2021 18:16
fix: Remove un necessary file from code base (googleapis#608)
feat: move migrations test modules to run against different emulator …
feat: update workflow files to uniformly distribute the test modules …
feat: update docs and nox file to compile it (googleapis#610)
c24t
reviewed
May 5, 2021
c24t
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
A few comments on test organization and style, but the tests themselves look great and this is a big obvious improvement.
I'll have to take another pass to check the test logic in more detail, but the tests I've checked so far all LGTM.
@larkee may have some insight on test strategy from python-spanner.
Sorry, something went wrong.
Comment thread
tests/unit/django_spanner/models.py
Outdated
Comment thread
tests/unit/django_spanner/test_compiler.py
Outdated
Comment thread
tests/unit/django_spanner/test_compiler.py
Outdated
Comment thread
tests/unit/django_spanner/test_expressions.py
Outdated
Comment thread
tests/unit/django_spanner/models.py
Outdated
Comment thread
tests/unit/django_spanner/models.py
Outdated
vi3k6i5
force-pushed
the
unit_tests_2
branch
2 times, most recently
from
96170b4 to
b4a8831
Compare
May 5, 2021 13:48
c24t
approved these changes
May 17, 2021
c24t
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Tests look great, thanks for the updates
Sorry, something went wrong.
This was referenced Apr 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: added unit test with coverage of 60 %