This repository was archived by the owner on Jun 8, 2026. It is now read-only.
feat: Add open telemetry trace in schema and related unit tests - #648
Merged
vi3k6i5 merged 15 commits intoJun 25, 2021
Merged
vi3k6i5 merged 15 commits into
vi3k6i5 merged 15 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
chore: add a Code of Conduct (googleapis#604)
fix: lint_setup_py was failing in Kokoro is now fixed (googleapis#607)
…into opentelemetry
…into opentelemetry
larkee
reviewed
Jun 18, 2021
larkee
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM, although I'm not very familiar with Django usage.
For CloudSpannerDjango.alter_field, I noticed that the method is _alter_field. Should the trace reflect this? Do users call this directly?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
users are not going to call this method directly, this trace is added more for keeping track. Wherever calls to backend takes place then how long those calls are taking. |
Sorry, something went wrong.
asthamohta
approved these changes
Jun 24, 2021
This was referenced Apr 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tracing in schema with related checks in unit tests.
Fixes #633 🦕