This repository was archived by the owner on May 14, 2026. It is now read-only.
feat: tweak table dropping mechanism - #28
Merged
IlyaFaer merged 5 commits intoMar 18, 2021
Merged
IlyaFaer merged 5 commits into
IlyaFaer merged 5 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
@larkee, I've been using this method from the beginning. In fact most of the testing cleanups will fail without these changes - meaning all the screenshots with test logs, I've been sending you during the last month, were based on these changes. |
Sorry, something went wrong.
larkee
reviewed
Mar 16, 2021
larkee
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM although I would prefer a couple unit tests for this.
Also, the compliance_test is failing to run:
INTERNALERROR> sqlalchemy.exc.ArgumentError: Could not parse rfc1738 URL from string 'None'
Any ideas on what is causing this break?
Sorry, something went wrong.
larkee
reviewed
Mar 17, 2021
Comment thread
google/cloud/sqlalchemy_spanner/sqlalchemy_spanner.py
larkee
approved these changes
Mar 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR requires changes of the #277 to be merged first.